fix(runtime): coordinate task cancellation lifecycle#136
Merged
Conversation
0649a92 to
81dfdfc
Compare
81dfdfc to
f24d021
Compare
…fecycle # Conflicts: # src/global_state/qihe.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the T4 runtime lifecycle work from the architecture audit. This change adds shared cancellation tokens and request/server cancellation plumbing, keeps request, shutdown, formatter, and Qihe cancellation token/process-driven at the runtime boundary, maps explicit cancellations to RequestCancelled while preserving stale-analysis retry behavior, changes the task pool to weighted fairness, and contains panics at request/background progress boundaries. Formatter and Qihe external processes now use cancellable process helpers that manage stdin/stdout/stderr and kill process trees; Qihe runs also use run-scoped progress tokens and final commit guards so stale or cancelled runs cannot publish diagnostics. Semantic-token delta cache updates now run as accepted response effects on the main loop, while Salsa synthetic cancellation remains confined to DB change/reload boundaries. Validation:
cargo fmt --all -- --check;cargo clippy --workspace --all-targets -- -D warnings;rustup run nightly cargo test --workspace;git diff --check.