Skip to content

fix(runtime): coordinate task cancellation lifecycle#136

Merged
hongjr03 merged 2 commits into
masterfrom
fix/task-runtime-lifecycle
May 26, 2026
Merged

fix(runtime): coordinate task cancellation lifecycle#136
hongjr03 merged 2 commits into
masterfrom
fix/task-runtime-lifecycle

Conversation

@hongjr03
Copy link
Copy Markdown
Member

@hongjr03 hongjr03 commented May 25, 2026

Implements the T4 runtime lifecycle work from the architecture audit. This change adds shared cancellation tokens and request/server cancellation plumbing, keeps request, shutdown, formatter, and Qihe cancellation token/process-driven at the runtime boundary, maps explicit cancellations to RequestCancelled while preserving stale-analysis retry behavior, changes the task pool to weighted fairness, and contains panics at request/background progress boundaries. Formatter and Qihe external processes now use cancellable process helpers that manage stdin/stdout/stderr and kill process trees; Qihe runs also use run-scoped progress tokens and final commit guards so stale or cancelled runs cannot publish diagnostics. Semantic-token delta cache updates now run as accepted response effects on the main loop, while Salsa synthetic cancellation remains confined to DB change/reload boundaries. Validation: cargo fmt --all -- --check; cargo clippy --workspace --all-targets -- -D warnings; rustup run nightly cargo test --workspace; git diff --check.

@hongjr03 hongjr03 force-pushed the fix/task-runtime-lifecycle branch from 0649a92 to 81dfdfc Compare May 25, 2026 06:48
@hongjr03 hongjr03 force-pushed the fix/task-runtime-lifecycle branch from 81dfdfc to f24d021 Compare May 25, 2026 08:16
@hongjr03 hongjr03 marked this pull request as ready for review May 25, 2026 18:30
…fecycle

# Conflicts:
#	src/global_state/qihe.rs
@hongjr03 hongjr03 merged commit 13dd1f5 into master May 26, 2026
7 checks passed
@hongjr03 hongjr03 deleted the fix/task-runtime-lifecycle branch May 26, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant