fix(ide): apply manifest predefines to navigation#142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manifest
definesalready fed compilation diagnostics and include discovery, but editor features that rely on the ordinary parse path still used an empty preprocessor configuration. This change stores the resolved preprocess config per file when project state is applied, then uses it for both IDE parsing and the default preprocessor index soifdef-selected branches, goto definition, and reference search share the same manifest macro state. Validation:cargo fmt --all -- --check;cargo check -p ide;cargo test -p ide manifest_predefines -- --nocapture;cargo test -p base-db preprocessor_index_honors_predefined_conditional_includes -- --nocapture;cargo test -p ide parsed_file_nodes_survive_parse_lru_eviction -- --nocapture;git diff --check.