Skip to content

fix(ci): isolate web smoke dependencies#231

Merged
hongjr03 merged 1 commit into
masterfrom
fix/playwright-browser-install-ci
Jun 5, 2026
Merged

fix(ci): isolate web smoke dependencies#231
hongjr03 merged 1 commit into
masterfrom
fix/playwright-browser-install-ci

Conversation

@hongjr03
Copy link
Copy Markdown
Member

@hongjr03 hongjr03 commented Jun 5, 2026

Summary

  • Move @vscode/test-web and its Playwright browser dependency into a private editors/vscode/test-web package.
  • Make the VS Code Web Smoke job install and cache that package separately.
  • Keep extension package installs free of browser install scripts for package jobs, including Alpine.

Testing

  • actionlint .github/workflows/ci.yml .github/workflows/release.yml
  • npm ci in editors/vscode
  • npm ci in editors/vscode/test-web
  • npm run typecheck
  • npm --prefix test-web run typecheck
  • npm test
  • npm run bundle:browser
  • npm run bundle:test-web
  • npm --prefix test-web test reached the runner after typecheck, then failed locally while downloading VS Code Stable with ECONNRESET from update.code.visualstudio.com.

@hongjr03 hongjr03 merged commit a597795 into master Jun 5, 2026
22 of 24 checks passed
@hongjr03 hongjr03 deleted the fix/playwright-browser-install-ci branch June 5, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant