feat(hir): add package and subroutine containers by hongjr03 · Pull Request #4 · pascal-lab/vide

hongjr03 · 2025-11-04T12:12:38Z

This PR adds support for packages and subroutines as new container types in the hir crate. It updates the container system and database queries so that packages and subroutines can be resolved and displayed like other containers.

Copilot

Pull Request Overview

This PR adds comprehensive support for SystemVerilog packages, including package declarations, imports/exports, and various member types (typedefs, structs, classes, subroutines). It extends the HIR (High-level Intermediate Representation) to handle packages alongside existing constructs like modules and blocks.

Key changes:

Introduces package declaration support with wrapper types (PackageDeclaration, PackageHeader)
Extends HIR to support packages, typedefs, structs, classes, and subroutines across all container types
Adds comprehensive handling of package imports/exports and member types

Reviewed Changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
crates/syntax/src/slang_ext/package.rs	New wrapper types for package declarations and headers with AST node trait implementations
crates/hir/src/hir_def/package.rs	Complete package HIR definition including lowering logic for package members and exports
crates/hir/src/hir_def/typedef.rs	New typedef HIR representation with source mapping and lowering utilities
crates/hir/src/hir_def/subroutine.rs	Extensive subroutine support with port definitions, body lowering, and container integration
crates/hir/src/hir_def/aggregate.rs	New aggregate type support (structs, unions, classes) with member definitions
crates/hir/src/hir_def/module.rs	Extended module lowering to handle new member types and comprehensive pattern matching
crates/hir/src/hir_def/file.rs	File-level package registration and support for file-scoped subroutines and other constructs
crates/hir/src/hir_def/block.rs	Block-level typedef and struct support with proper lowering
crates/hir/src/container.rs	Container system extended to include packages and subroutines as first-class containers
crates/hir/src/db.rs	Database queries for package and subroutine retrieval

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-04T12:15:36Z

+    fn to_node(&self, tree: &'a syntax::SyntaxTree) -> Option<ast::TypedefDeclaration<'a>> {
+        let mut node = self.node.to_node(tree)?;
+        while !ast::TypedefDeclaration::can_cast(node.kind()) {
+            node = node.children().find_map(|elem| elem.as_node()).unwrap();


Potential panic if no node is found. The .unwrap() call will panic if find_map returns None. Consider propagating the error by using ? instead: node = node.children().find_map(|elem| elem.as_node())?;

Suggested change

node = node.children().find_map(|elem| elem.as_node()).unwrap();

node = node.children().find_map(|elem| elem.as_node())?;

Copilot · 2025-11-04T12:15:37Z

+    fn to_node(&self, tree: &'a syntax::SyntaxTree) -> Option<ast::PackageImportDeclaration<'a>> {
+        let mut node = self.node.to_node(tree)?;
+        while !ast::PackageImportDeclaration::can_cast(node.kind()) {
+            node = node.children().find_map(|elem| elem.as_node()).unwrap();


Potential panic if no node is found. The .unwrap() call will panic if find_map returns None. Consider propagating the error by using ? instead: node = node.children().find_map(|elem| elem.as_node())?;

Suggested change

node = node.children().find_map(|elem| elem.as_node()).unwrap();

node = node.children().find_map(|elem| elem.as_node())?;

Copilot · 2025-11-04T12:15:37Z

+    fn to_node(&self, tree: &'a syntax::SyntaxTree) -> Option<ast::StructUnionType<'a>> {
+        let mut node = self.node.to_node(tree)?;
+        while !ast::StructUnionType::can_cast(node.kind()) {
+            node = node.children().find_map(|elem| elem.as_node()).unwrap();


Potential panic if no node is found. The .unwrap() call will panic if find_map returns None. Consider propagating the error by using ? instead: node = node.children().find_map(|elem| elem.as_node())?;

Copilot · 2025-11-04T12:15:37Z

+    fn to_node(&self, tree: &'a syntax::SyntaxTree) -> Option<ast::ClassDeclaration<'a>> {
+        let mut node = self.node.to_node(tree)?;
+        while !ast::ClassDeclaration::can_cast(node.kind()) {
+            node = node.children().find_map(|elem| elem.as_node()).unwrap();


Potential panic if no node is found. The .unwrap() call will panic if find_map returns None. Consider propagating the error by using ? instead: node = node.children().find_map(|elem| elem.as_node())?;

Suggested change

node = node.children().find_map(|elem| elem.as_node()).unwrap();

node = node.children().find_map(|elem| elem.as_node())?;

Copilot · 2025-11-04T12:15:37Z

+    fn to_node(&self, tree: &'a syntax::SyntaxTree) -> Option<PackageDeclaration<'a>> {
+        let mut node = self.node.to_node(tree)?;
+        while !PackageDeclaration::can_cast(node.kind()) {
+            node = node.children().find_map(|elem| elem.as_node())?;


Inconsistent error handling pattern. Lines 106, and similar patterns in other files use .unwrap(), while this line uses ?. For consistency and better error handling, all these patterns should use ? to propagate the error rather than panicking.

Copilot · 2025-11-04T12:15:38Z

+#[derive(Clone, Copy, PartialEq, Eq, Hash, Debug)]
+pub struct LocalBlockId(pub StmtId);


The field of LocalBlockId is now public, changing it from a newtype pattern with encapsulation to an exposed implementation detail. If this is intentional, consider whether this breaks encapsulation or if accessor methods would be more appropriate.

Copilot · 2025-11-04T12:15:38Z

+impl From<InstantiationSrc> for syntax::ptr::SyntaxNodePtr {
+    fn from(src: InstantiationSrc) -> Self {
+        match src {
+            InstantiationSrc::HierarchyInstantiation(ptr) => ptr,
+            InstantiationSrc::PrimitiveInstantiation(ptr) => ptr,


[nitpick] The From implementation for InstantiationSrc could be better served by implementing a ptr() method similar to other source types (see TypedefSrc::ptr() on line 75-78 of typedef.rs). This would be more consistent with the codebase pattern and provide better encapsulation.

Suggested change

impl From<InstantiationSrc> for syntax::ptr::SyntaxNodePtr {

fn from(src: InstantiationSrc) -> Self {

match src {

InstantiationSrc::HierarchyInstantiation(ptr) => ptr,

InstantiationSrc::PrimitiveInstantiation(ptr) => ptr,

impl InstantiationSrc {

pub fn ptr(&self) -> syntax::ptr::SyntaxNodePtr {

match self {

InstantiationSrc::HierarchyInstantiation(ptr) => *ptr,

InstantiationSrc::PrimitiveInstantiation(ptr) => *ptr,

Copilot · 2025-11-04T12:15:38Z

-hashbrown = { version = "0.12.3", features = [
-    "inline-more",
-], default-features = false }
+hashbrown = { version = "0.12.3", features = ["inline-more"], default-features = false }


[nitpick] Formatting-only change that condenses multi-line dependency into single line. While this doesn't affect functionality, consider whether this aligns with project formatting standards for readability of complex dependency specifications.

Suggested change

hashbrown = { version = "0.12.3", features = ["inline-more"], default-features = false }

hashbrown = {

version = "0.12.3",

features = ["inline-more"],

default-features = false

}

feat(vscode): add TextMate grammars for verilog/systemverilog

* chore: add .clice/ to .gitignore * chore(vscode): add packaging script and ignore artifacts * fix(ci): package vscode extension non-interactively

roife · 2026-01-14T07:09:38Z

Why was this PR closed, I made some modifications to it, planning to push it up

hongjr03 · 2026-01-14T07:28:07Z

I thought we weren’t going to support SV features, so I reimplemented the completion features without modifying the hir crates in #6.

I should have confirmed this with you beforehand and sorry about that. Let me reopen this PR.

…on resolution

hongjr03 requested a review from Copilot November 4, 2025 12:12

hongjr03 changed the base branch from master to completion November 4, 2025 12:13

Copilot AI reviewed Nov 4, 2025

View reviewed changes

This was referenced Nov 4, 2025

feat(hir): completion foundation #5

Closed

(wip) feat(ide): completion #1

Closed

hongjr03 deleted the branch pascal-lab:completion November 29, 2025 11:11

hongjr03 closed this Nov 29, 2025

hongjr03 reopened this Nov 30, 2025

hongjr03 and others added 7 commits December 22, 2025 18:49

feat(vscode): add TextMate grammars for verilog/systemverilog

942d0df

Merge pull request #9 from hongjr03/feat/textmate-grammars

b493af0

feat(vscode): add TextMate grammars for verilog/systemverilog

style: format

dfb9538

chore: update slang repo

7d5f4de

style: format

303beec

chore: bump slang

9464a1a

chore: add vscode packaging script and update .gitignore (#10)

8287a39

* chore: add .clice/ to .gitignore * chore(vscode): add packaging script and ignore artifacts * fix(ci): package vscode extension non-interactively

hongjr03 closed this Jan 13, 2026

hongjr03 reopened this Jan 14, 2026

hongjr03 and others added 9 commits January 16, 2026 23:12

feat(syntax): add package AST helpers

9d88382

feat(hir): add package, struct, and typedef support

3f75896

feat(hir): add class method support in HIR

08d7580

feat(hir): add file-level function declaration support

2faf328

fix(hir): add basic EnumType support in data type lowering

ea7b9e7

feat(hir): record class base names

ed32093

refactor(hir): remove unused container variants and simplify expressi…

06f6341

…on resolution

fix(hir, ide, syntax): remove unsupported grammar

6cb552c

fix(hir): clean

e48823e

roife force-pushed the feature/hir-enrich branch from 1a75fc2 to e48823e Compare January 16, 2026 15:42

roife merged commit f2451a4 into pascal-lab:completion Jan 16, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(hir): add package and subroutine containers#4

feat(hir): add package and subroutine containers#4
roife merged 16 commits into
pascal-lab:completionfrom
hongjr03:feature/hir-enrich

hongjr03 commented Nov 4, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

roife commented Jan 14, 2026

Uh oh!

hongjr03 commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	node = node.children().find_map(\|elem\| elem.as_node()).unwrap();
	node = node.children().find_map(\|elem\| elem.as_node())?;

		#[derive(Clone, Copy, PartialEq, Eq, Hash, Debug)]
		pub struct LocalBlockId(pub StmtId);

Conversation

hongjr03 commented Nov 4, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key changes:

Reviewed Changes

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

roife commented Jan 14, 2026

Uh oh!

hongjr03 commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants