fix: allow deleting walls and slabs via floating action menu#180
Open
nnhhoang wants to merge 2 commits intopascalorg:mainfrom
Open
fix: allow deleting walls and slabs via floating action menu#180nnhhoang wants to merge 2 commits intopascalorg:mainfrom
nnhhoang wants to merge 2 commits intopascalorg:mainfrom
Conversation
|
@nnhhoang you should add a vid of the full flow btw |
Walls and slabs were excluded from ALLOWED_TYPES in FloatingActionMenu, so no delete UI appeared when selecting them. Added wall/slab to the allowed types and show only the delete button (no move/duplicate) since they are structural elements. Usage: switch to select mode (V), click a wall or slab, then use the floating trash icon or press Delete/Backspace to remove it. Closes pascalorg#156
ac668b1 to
1213cae
Compare
Author
|
@kleenkanteen here is the flow |
Contributor
|
Thanks for the PR. moving.while.holding.tool.-.sledgehammer.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
ALLOWED_TYPESinFloatingActionMenu, so no delete UI appeared when selecting themwallandslabto the allowed types with a newDELETE_ONLY_TYPESlistonMove/onDuplicateoptional inNodeActionMenuso structural elements show only the delete buttonCloses #156
Test plan
bun run check— 0 issues)