Skip to content

feat: improve thumbnails and reduce editor rerenders #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
open-pascal merged 1 commit into from
Apr 13, 2026
Merged

feat: improve thumbnails and reduce editor rerenders #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/editor/src/components/editor/floating-action-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ export function FloatingActionMenu() {
const selectedIds = useViewer((s) => s.selection.selectedIds)
const nodes = useScene((s) => s.nodes)
const mode = useEditor((s) => s.mode)
const setMode = useEditor((s) => s.setMode)
const isFloorplanHovered = useEditor((s) => s.isFloorplanHovered)
const setMovingNode = useEditor((s) => s.setMovingNode)
const setSelection = useViewer((s) => s.setSelection)
Expand Down Expand Up @@ -199,11 +198,11 @@ export function FloatingActionMenu() {
const handleDelete = useCallback(
(e: React.MouseEvent) => {
e.stopPropagation()
// Activate delete mode (sledgehammer tool) instead of deleting directly
if (!selectedId) return
setSelection({ selectedIds: [] })
setMode('delete')
useScene.getState().deleteNode(selectedId as AnyNodeId)
},
[setSelection, setMode],
[selectedId, setSelection],
)

if (!(selectedId && node && isValidType && !isFloorplanHovered && mode !== 'delete')) return null
Expand Down
Loading