fix: restore fence tool handlers dropped by null-guard commit#318
Merged
Conversation
251af2c added a `?.` on cursorRef in onGridClick but inadvertently deleted the closing braces, the trailing reset block, and the onKeyDown/onKeyUp/onCancel handlers — leaving onGridClick syntactically unterminated and three undefined references at the emitter.on/off sites. Restores the deleted block verbatim, keeping the optional-chaining null guard on cursorRef. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
251af2c("fix: add null guards for cursorRef in fence and wall tool click handlers", merged in #315 / portforward of pr-309) added a?.oncursorRef.currentinonGridClick, but the same commit accidentally deleted:elsebranch andonGridClickitself, leaving the function syntactically unterminated, andpreviewRef.current.visible = false,buildingState.current = 1,setDraftMeasurement(null)), andonKeyDown/onKeyUp/onCancelhandler definitions — which are still referenced at theemitter.on(...)/emitter.off(...)sites below.This left
mainfailing to build:Restores the deleted block verbatim from the prior state (5bd2f51), keeping the intended
cursorRef.current?.optional-chaining null guard.Test plan
bun typecheck(passes)bun run build(passes — both editor packages and downstream community app)🤖 Generated with Claude Code