Skip to content

Suspend arrow keys while ruler settings are open#274

Merged
pascalpp merged 1 commit into
mainfrom
pascal/272-suspend-arrow-keys
Jun 28, 2026
Merged

Suspend arrow keys while ruler settings are open#274
pascalpp merged 1 commit into
mainfrom
pascal/272-suspend-arrow-keys

Conversation

@pascalpp

Copy link
Copy Markdown
Owner

Fixes #272.

Summary

  • Replaced the stale preferencesWindowOpen boolean with owner-tracked ruler interaction suspension.
  • Suspended only the ruler attached to the per-ruler Settings panel, and moved that suspension when the reusable panel switches rulers.
  • Let arrow-key events pass through while ruler interaction is suspended or the ruler window is not key, so settings controls can handle navigation.

Root Cause

The previous state model only represented the global Preferences window. After multiple rulers and the per-ruler Settings panel were introduced, the key listener could still consume arrow keys for ruler nudging while the Settings panel was open.

Validation

  • xcodebuild -project "Free Ruler.xcodeproj" -scheme "Free Ruler" test -only-testing:FreeRulerTests
  • git diff --check

@pascalpp pascalpp changed the title [codex] Suspend arrow keys while ruler settings are open Suspend arrow keys while ruler settings are open Jun 28, 2026
@pascalpp pascalpp marked this pull request as ready for review June 28, 2026 03:55
@pascalpp pascalpp merged commit d38ca4f into main Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suspend arrow key listeners while Ruler settings panel is open

1 participant