fix: deserialize IP address if returned by API#3
Merged
Conversation
mariusvirb
suggested changes
Sep 30, 2022
mariusvirb
left a comment
mariusvirb
left a comment
There was a problem hiding this comment.
Please remove package-lock.json, otherwise lg2m
Contributor
Author
Done @mariusvirb |
mariusvirb
suggested changes
Oct 4, 2022
mariusvirb
left a comment
mariusvirb
left a comment
There was a problem hiding this comment.
@MrPrashantT, this does not seem right 🤔 it seems package-lock does existing in our main branch 🤯 Well, since we didn't update any dependencies, please revert this file to it's original form.
| metadata: {[x: string]: any} | null; | ||
| metadata: { [x: string]: any } | null; | ||
| watchlist: Watchlist | null; | ||
| network: {} | null; |
There was a problem hiding this comment.
Just noticed, this should be Network.
Contributor
Author
There was a problem hiding this comment.
Both fixed in latest commit.
…w Network class rather than generic object.
mariusvirb
approved these changes
Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for issue 28773.