Add loadAppFonts#66
Merged
Merged
Conversation
passsy
reviewed
Nov 6, 2024
passsy
reviewed
Nov 20, 2024
passsy
reviewed
Nov 20, 2024
| path: test/ | ||
| retention-days: 7 | ||
|
|
||
| test_windows: |
Owner
There was a problem hiding this comment.
I'm impressed how easy it was to add windows support
Owner
|
Seems complete for me now. Please test it once more before we land it 🤓 |
Collaborator
Author
|
LGTM! Everything works and the code is very understandable. Thanks for taking care! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a top level function
loadAppFontsandloadFontto be used in tests to load fonts so they are visible in the screenshots taken bytakeScreenshot.