[WIP] improvement: use jaspr to render html page#76

Merged

passsy merged 10 commits into

passsy:mainfrom

schultek:jaspr-timeline

Dec 12, 2024

Contributor

schultek commented Nov 22, 2024

@passsy What do you think?

Just the proof of concept for now, can be improved.


          improvement: use jaspr to render html page

e677e42

Owner

passsy commented Nov 22, 2024

Awesome! I was a bit worried that rendering would take too long. I measured 35ms. That's a tax I'm willing to pay!

I already feel more confident writing logic in Jaspr vs plain HTML/CSS. I'm happy to take it over from here ✌️

Contributor Author

schultek commented Nov 22, 2024 •

edited

Loading

Very cool.

I'm setting up the client logic right now, give me another day then you can take over 😊


          rewrite client side logic for timeline webpage in jaspr

c0c97ee

Contributor Author

schultek commented Nov 23, 2024

Now its fully migrated, Jaspr renders both server-side (the html generation) and client side (the interactivity).

To keep the setup simple, I added a tooling script that compiles the client-side code to js and places it in the script.js.dart file. So whenever the client-side code is modified, run dart run tool/compile_js.dart.

For now I just mirrored the exact design and functionality of the existing website, but I'm happy to help with improving this as a follow up if you want.


          Rename generated JS file to .g.dart

5ef1c99

passsy reviewed

View reviewed changes

lib/src/timeline/html/print_html.dart

passsy reviewed

View reviewed changes

lib/src/timeline/html/web/run_app.dart Outdated

passsy reviewed

View reviewed changes

lib/src/timeline/html/web/app.dart Outdated

passsy reviewed

View reviewed changes

lib/src/timeline/html/web/app.dart Outdated

passsy reviewed

View reviewed changes

lib/src/timeline/html/web/app.dart Outdated


          Make analyzer happy

f9980a5

passsy reviewed

View reviewed changes

lib/src/timeline/html/web/run_app.dart Outdated

Kilian Schulte added 2 commits

November 25, 2024 19:46


          split into server and client apps

ee7d928


          Merge branch 'jaspr-timeline' of https://github.com/schultek/spot int…

128bd42

…o jaspr-timeline

# Conflicts:
#	lib/src/timeline/html/print_html.dart
#	lib/src/timeline/html/web/timeline_app.dart

schultek marked this pull request as ready for review

November 25, 2024 18:51

schultek requested a review from passsy

November 25, 2024 18:51

Kilian Schulte and others added 4 commits

December 6, 2024 15:57


          refactor: change jaspr to 0.15 to allow dart 3.0

1a5a2e6


          refactor: move all css to jaspr styles

b7644a1


          Cleanup

73c8ae3


          Ignore formatting in script.js.g.dart

cd8455a

passsy merged commit 985c14d into passsy:main

Owner

passsy commented Dec 12, 2024

Thanks so much @schultek for your efforts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet