AES functions added #137
AES functions added #137
Conversation
yakuter
left a comment
yakuter
left a comment
There was a problem hiding this comment.
I tried it. Works fine, thank you @yusufpapurcu great job ;)
| @@ -0,0 +1,52 @@ | |||
| package app | |||
There was a problem hiding this comment.
It would be beneficial for all to have test cases (unit tests) as well. This way, no one need to run entire application to be sure whether it is working or not. @yusufpapurcu
Just a suggestion ;)
Well done, you did a great job, by the way ;)
|
As @mrturkmencom mentioned, tests are important. Can you add test for two functions in crypto.go. By the way let me show you something :D Now we can encrypt the json data it self with a transmission key generated in server side and changes with every token generation :) Frontend: Backend: |
|
I'll write test but have a little problem. Can i add tests commit here. Or must I open new pr for this. |
|
I already merged. So please open new PR. |
3 participants
Functions tested with CryptoJS on the signup function. Worked.