Skip to content

Set PyMuPDF optional for easier installation. New workflow that only uses pip#115

Merged
jiedxu merged 28 commits intomasterfrom
poetry
Apr 16, 2023
Merged

Set PyMuPDF optional for easier installation. New workflow that only uses pip#115
jiedxu merged 28 commits intomasterfrom
poetry

Conversation

@jiedxu
Copy link
Copy Markdown
Collaborator

@jiedxu jiedxu commented Apr 15, 2023

To close #110. Now it's not necessary to install PyMuPDF during development and usage.

For example, run:

$ poetry install --with dev

To install PyMuPDF, run:

$ poetry install --with dev,pdf

Also, a pre-commit hook, check-docstring-first, is disabled, because it cannot handle the summary of PDF_FEATURES in src/cmdict/pdf_tools.py.

@jiedxu jiedxu self-assigned this Apr 15, 2023
@jiedxu jiedxu requested review from zequnyu and removed request for zequnyu April 15, 2023 15:04
@jiedxu jiedxu changed the title Set PyMuPDF optional for easier installation Set PyMuPDF optional for easier installation. New workflow that only uses pip Apr 16, 2023
@jiedxu jiedxu linked an issue Apr 16, 2023 that may be closed by this pull request
@jiedxu jiedxu merged commit 6018643 into master Apr 16, 2023
@jiedxu jiedxu deleted the poetry branch April 16, 2023 08:24
@jiedxu jiedxu added the CI/CD Fix or improve tests or workflows label Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Fix or improve tests or workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI cannot install Poetry Make PDF-related features optional for easier installation

1 participant