PatchWork AutoFix

patchwork/app.py

@@ -59,6 +59,9 @@ def list_option_callback(ctx: click.Context, param: click.Parameter, value: str
 
 
 def find_patchflow(possible_module_paths: Iterable[str], patchflow: str) -> Any | None:
+    # Define a whitelist of allowed module paths
+    allowed_modules = {'allowed_module1', 'allowed_module2', 'allowed_module3'}
+
     for module_path in possible_module_paths:
         try:
             spec = importlib.util.spec_from_file_location("custom_module", module_path)
@@ -72,9 +75,12 @@ def find_patchflow(possible_module_paths: Iterable[str], patchflow: str) -> Any
             logger.debug(f"Patchflow {patchflow} not found as a file/directory in {module_path}")
 
         try:
-            module = importlib.import_module(module_path)
-            logger.info(f"Patchflow {patchflow} loaded from {module_path}")
-            return getattr(module, patchflow)
+            if module_path in allowed_modules:
+                module = importlib.import_module(module_path)
+                logger.info(f"Patchflow {patchflow} loaded from {module_path}")
+                return getattr(module, patchflow)
+            else:
+                logger.debug(f"Module {module_path} is not in the whitelist.")
         except ModuleNotFoundError:
             logger.debug(f"Patchflow {patchflow} not found as a module in {module_path}")
         except AttributeError:

patchwork/common/tools/bash_tool.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import shlex
 import subprocess
 from pathlib import Path
 
@@ -45,7 +46,7 @@ def execute(
 
         try:
             result = subprocess.run(
-                command, shell=True, cwd=self.path, capture_output=True, text=True, timeout=60  # Add timeout for safety
+                shlex.split(command), shell=False, cwd=self.path, capture_output=True, text=True, timeout=60  # Add timeout for safety
             )
             return result.stdout if result.returncode == 0 else f"Error: {result.stderr}"
         except subprocess.TimeoutExpired:

patchwork/common/tools/csvkit_tool.py

@@ -118,8 +118,9 @@ def execute(self, files: list[str], query: str) -> str:
         if db_path.is_file():
             with sqlite3.connect(str(db_path)) as conn:
                 for file in files:
+                    table_name = file.removesuffix('.csv')
                     res = conn.execute(
-                        f"SELECT 1 from {file.removesuffix('.csv')}",
+                        "SELECT 1 FROM ?", (table_name,)
                     )
                     if res.fetchone() is None:
                         files_to_insert.append(file)

patchwork/common/utils/dependency.py

@@ -6,9 +6,12 @@
     "notification": ["slack_sdk"],
 }
 
+__WHITELISTED_MODULES = {"semgrep", "depscan", "slack_sdk"}
 
 @lru_cache(maxsize=None)
 def import_with_dependency_group(name):
+    if name not in __WHITELISTED_MODULES:
+        raise ImportError(f"Module {name} is not allowed for import.")
     try:
         return importlib.import_module(name)
     except ImportError:
@@ -20,6 +23,5 @@ def import_with_dependency_group(name):
             error_msg = f"Please `pip install patchwork-cli[{dependency_group}]` to use this step"
         raise ImportError(error_msg)
 
-
 def slack_sdk():
     return import_with_dependency_group("slack_sdk")

patchwork/common/utils/step_typing.py

@@ -105,8 +105,14 @@ def validate_step_type_config_with_inputs(
     return True, step_type_config.msg
 
 
+ALLOWED_MODULES = {"expected_module1", "expected_module2"}
+
 def validate_step_with_inputs(input_keys: Set[str], step: Type[Step]) -> Tuple[Set[str], Dict[str, str]]:
     module_path, _, _ = step.__module__.rpartition(".")
+
+    if module_path not in ALLOWED_MODULES:
+        raise ValueError(f"Unauthorized module path: {module_path}")
+
     step_name = step.__name__
     type_module = importlib.import_module(f"{module_path}.typed")
     step_input_model = getattr(type_module, f"{step_name}Inputs", __NOT_GIVEN)

patchwork/steps/CallShell/CallShell.py

@@ -46,7 +46,8 @@ def __parse_env_text(env_text: str) -> dict[str, str]:
         return env
 
     def run(self) -> dict:
-        p = subprocess.run(self.script, shell=True, capture_output=True, text=True, cwd=self.working_dir, env=self.env)
+        command = shlex.split(self.script)
+        p = subprocess.run(command, shell=False, capture_output=True, text=True, cwd=self.working_dir, env=self.env)
         try:
             p.check_returncode()
         except subprocess.CalledProcessError as e: