perf: studysession caching of anticipated card data #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and implement hydration logic (again, migrated from StudySession.vue)
NiloCK
changed the title
prevent null returns if db-work is ongoing
instead of waiting for entire buffer to hydrate
now async after making the hydrationQ more robust against timing issues
prevents circular dependency between db and common-ui packages
and use a generic decorator to pass type safety of ViewComponents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to the mood of the backend, studySessions were sometimes laggy because card lookups require 2 db trips (card info, then data hydration).
This PR moves some db logic from common-ui/StudySession.vue to db/SessionController.ts (better location) and improves it w/ a running cache of ~5 cards worth of hydrated data.