Feature/v3.11.x/1115 osx executable args issue #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
witcher112
requested review from
Dzejkop and
genail
and removed request for
Dzejkop
Contributor
Author
|
No changelog update since it's a fix for feature that is currently being added. |
genail
approved these changes
Dec 13, 2018
Dzejkop
reviewed
Dec 18, 2018
| string executablePath = Path.Combine(_app.LocalDirectory.Path, appVersion.MainExecutable); | ||
|
|
||
| if (File.Exists(executablePath)) | ||
| bool isOSXApp = platformType == PlatformType.OSX && |
Contributor
There was a problem hiding this comment.
Is there any chance that Platform.GetPlatformType returns OSX but the application isn't an OSX app?
Contributor
Author
There was a problem hiding this comment.
Nope, it's always the same.
Contributor
There was a problem hiding this comment.
The we shouldn't need all the other conditions, right?
...
executablePath.EndsWith(".app") &&
Directory.Exists(executablePath);
Contributor
Author
There was a problem hiding this comment.
This isn't checking whether application platform that secret we are using is OSX, but whether the appVersion.MainExecutable points to valid OSX .app.
Dzejkop
suggested changes
Dec 18, 2018
| string executablePath = Path.Combine(_app.LocalDirectory.Path, appVersion.MainExecutable); | ||
|
|
||
| if (File.Exists(executablePath)) | ||
| bool isOSXApp = platformType == PlatformType.OSX && |
Contributor
There was a problem hiding this comment.
The we shouldn't need all the other conditions, right?
...
executablePath.EndsWith(".app") &&
Directory.Exists(executablePath);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Version.csup to date