Features/v3.17.x.x Improved diff update#172
Merged
witcher112 merged 3 commits intoexperimental/improved-download-unpacking-installationfrom Sep 22, 2021
Merged
Conversation
…ry change at app_data.json. Refactoring LocalMetaData
Szczyrk
changed the base branch from
dev/v3.17.x.x
to
experimental/improved-download-unpacking-installation
witcher112
requested changes
Sep 21, 2021
Assets/PatchKit Patcher/Scripts/AppUpdater/Commands/InstallDiffCommand.cs
Outdated
Show resolved
Hide resolved
Assets/PatchKit Patcher/Scripts/AppUpdater/Commands/InstallContentCommand.cs
Show resolved
Hide resolved
Assets/PatchKit Patcher/Scripts/AppUpdater/Commands/InstallDiffCommand.cs
Outdated
Show resolved
Hide resolved
Assets/PatchKit Patcher/Scripts/AppUpdater/Commands/InstallDiffCommand.cs
Outdated
Show resolved
Hide resolved
Assets/PatchKit Patcher/Scripts/AppUpdater/Commands/InstallDiffCommand.cs
Outdated
Show resolved
Hide resolved
witcher112
requested changes
Sep 22, 2021
| @@ -594,67 +594,45 @@ private void PatchFile( | |||
| } | |||
|
|
|||
| _logger.LogDebug("Checking whether patching file content is necessary..."); | |||
Contributor
There was a problem hiding this comment.
This log is not longer accurate.
Collaborator
Author
There was a problem hiding this comment.
I think this log is not needed. I removed it
| _logger.LogDebug("Checking whether patching file content is necessary..."); | ||
| if (IsPatchingFileContentNecessary(fileName)) | ||
|
|
||
| _logger.LogDebug("Patching is necessary. Generating new file with patched content..."); |
Contributor
There was a problem hiding this comment.
This log should be rephrased.
Collaborator
Author
There was a problem hiding this comment.
I think this log is not needed. I removed it
witcher112
merged commit c76393e
into
experimental/improved-download-unpacking-installation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.