Skip to content

refactor stream#847

Merged
DavidBadura merged 1 commit into
4.0.xfrom
refactor-stream
Apr 24, 2026
Merged

refactor stream#847
DavidBadura merged 1 commit into
4.0.xfrom
refactor-stream

Conversation

@DavidBadura
Copy link
Copy Markdown
Member

@DavidBadura DavidBadura commented Apr 22, 2026

fix #729

The index and position remain unchanged. However, instead of having to implement the stream yourself, there is now a generic implementation available for use.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Hello 👋

here is the most recent benchmark result:

SimpleSetupTaggableStoreBench
=============================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.063ms (±0.00%)   | 1.329ms (±0.00%)   | -20.01%   | 36.306mb        | 36.824mb   | -1.41%      |
| benchLoad10000Events ()                | 66.014ms (±0.00%)  | 62.623ms (±0.00%)  | +5.41%    | 36.306mb        | 36.306mb   | -0.00%      |
| benchSave1Event ()                     | 1.239ms (±0.00%)   | 1.406ms (±0.00%)   | -11.89%   | 36.306mb        | 36.306mb   | -0.00%      |
| benchSave10000Events ()                | 298.674ms (±0.00%) | 318.131ms (±0.00%) | -6.12%    | 36.306mb        | 36.306mb   | -0.00%      |
| benchSave10000Aggregates ()            | 6.268s (±0.00%)    | 6.565s (±0.00%)    | -4.53%    | 36.306mb        | 36.306mb   | -0.00%      |
| benchSave10000AggregatesTransaction () | 4.186s (±0.00%)    | 4.183s (±0.00%)    | +0.07%    | 36.306mb        | 36.306mb   | -0.00%      |
| benchAppend1Event ()                   | 1.314ms (±0.00%)   | 1.574ms (±0.00%)   | -16.51%   | 36.306mb        | 36.306mb   | -0.00%      |
| benchAppend100Events ()                | 7.048ms (±0.00%)   | 7.193ms (±0.00%)   | -2.02%    | 36.306mb        | 36.306mb   | -0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                   | memory                                     |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 64.780ms (±0.00%) | 61.124ms (±0.00%) | +5.98%    | 35.210mb        | 35.210mb   | -0.00%      |
| benchLoad10000Events ()                | 1.255ms (±0.00%)  | 1.065ms (±0.00%)  | +17.93%   | 35.210mb        | 35.210mb   | -0.00%      |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

CommandToQueryBench
===================

+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
|                | time (kde mode)                                 | memory                                     |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
| subject        | Tag: <current>   | Tag: base        | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
| benchCreate () | 2.311ms (±0.00%) | 2.400ms (±0.00%) | -3.70%    | 4.727mb         | 4.976mb    | -5.01%      |
| benchUpdate () | 3.784ms (±0.00%) | 3.620ms (±0.00%) | +4.53%    | 4.913mb         | 4.889mb    | +0.49%      |
| benchBoth ()   | 6.312ms (±0.00%) | 6.270ms (±0.00%) | +0.66%    | 5.121mb         | 5.075mb    | +0.91%      |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 3.306ms (±0.00%)   | 3.271ms (±0.00%)   | +1.06%    | 35.833mb        | 35.834mb   | -0.00%      |
| benchSave10000Events () | 488.034ms (±0.00%) | 491.010ms (±0.00%) | -0.61%    | 35.903mb        | 35.969mb   | -0.18%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 2.749s (±0.00%) | 2.730s (±0.00%) | +0.68%    | 48.293mb        | 48.293mb   | -0.00%      |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.083ms (±0.00%)   | 1.038ms (±0.00%)   | +4.35%    | 35.140mb        | 35.206mb   | -0.19%      |
| benchLoad10000Events ()                | 65.648ms (±0.00%)  | 63.002ms (±0.00%)  | +4.20%    | 35.140mb        | 35.206mb   | -0.19%      |
| benchSave1Event ()                     | 1.219ms (±0.00%)   | 1.097ms (±0.00%)   | +11.12%   | 35.140mb        | 35.206mb   | -0.19%      |
| benchSave10000Events ()                | 277.735ms (±0.00%) | 278.656ms (±0.00%) | -0.33%    | 35.140mb        | 35.206mb   | -0.19%      |
| benchSave10000Aggregates ()            | 6.185s (±0.00%)    | 6.223s (±0.00%)    | -0.61%    | 35.140mb        | 35.206mb   | -0.19%      |
| benchSave10000AggregatesTransaction () | 4.090s (±0.00%)    | 4.125s (±0.00%)    | -0.84%    | 35.140mb        | 35.206mb   | -0.19%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 82.816ms (±0.00%) | 83.859ms (±0.00%) | -1.24%    | 35.720mb        | 35.720mb   | -0.00%      |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.098ms (±0.00%)   | 1.123ms (±0.00%)   | -2.26%    | 35.804mb        | 35.804mb   | -0.00%      |
| benchLoad10000Events ()                | 98.960ms (±0.00%)  | 94.959ms (±0.00%)  | +4.21%    | 35.804mb        | 35.804mb   | -0.00%      |
| benchSave1Event ()                     | 1.878ms (±0.00%)   | 1.674ms (±0.00%)   | +12.19%   | 35.804mb        | 35.804mb   | -0.00%      |
| benchSave10000Events ()                | 306.416ms (±0.00%) | 300.988ms (±0.00%) | +1.80%    | 35.806mb        | 35.806mb   | -0.00%      |
| benchSave10000Aggregates ()            | 9.776s (±0.00%)    | 9.724s (±0.00%)    | +0.54%    | 35.804mb        | 35.804mb   | -0.00%      |
| benchSave10000AggregatesTransaction () | 7.545s (±0.00%)    | 7.573s (±0.00%)    | -0.37%    | 36.044mb        | 36.045mb   | -0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura force-pushed the refactor-stream branch 3 times, most recently from a6c43f2 to 193d383 Compare April 22, 2026 17:57
@DavidBadura DavidBadura added this to the 4.0.0 milestone Apr 24, 2026
@DavidBadura DavidBadura added enhancement New feature or request BC-Break labels Apr 24, 2026
@DavidBadura DavidBadura marked this pull request as ready for review April 24, 2026 06:17
Comment thread src/Subscription/Engine/EventFilteredStoreMessageLoader.php
Comment thread src/Subscription/Store/DoctrineSubscriptionStore.php
@DavidBadura DavidBadura merged commit 466f278 into 4.0.x Apr 24, 2026
37 of 39 checks passed
@DavidBadura DavidBadura deleted the refactor-stream branch April 24, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BC-Break enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants