HydratorException should be Throwable#190
Merged
DavidBadura merged 1 commit intopatchlevel:1.24.xfrom May 2, 2026
Merged
Conversation
This is a technical BC break, but it's extremely unlikely that users will have implemented this interface on a non-throwable.
This fixes code for static analysers such as:
```php
try {
return $hydrator->extract($object);
} catch(HydratorException $e) {
throw new MyException('Foo', 0, $e);
}
```
DavidBadura
approved these changes
May 2, 2026
Member
DavidBadura
left a comment
DavidBadura
left a comment
There was a problem hiding this comment.
Oh yes, I don't think this BC break should affect anyone, since the sole purpose of this interface was to allow it to be used for catching. What do you think, @DanielBadura
Member
|
I'd consider this as a bug fix, so I'm fine with it 👍 |
DanielBadura
approved these changes
May 2, 2026
DavidBadura
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a technical BC break, but it's extremely unlikely that users will have implemented this interface on a non-throwable.
This fixes code for static analysers such as: