fix: do not wipe JSONC MCP configs when adding Patchloom - #248
Merged
Conversation
parseJsonObject treated any JSON.parse failure as an empty object, so Configure MCP overwrote VS Code mcp.json that used comments or trailing commas. Parse JSONC, preserve sibling servers, and refuse garbage without writing. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
marked this pull request as ready for review
August 28, 2026 14:23
SebTardif
enabled auto-merge (squash)
August 28, 2026 14:23
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configure MCP treated any
JSON.parsefailure as an empty object, so aVS Code
mcp.jsonthat used comments or a trailing comma was rewrittento only
patchloom. Other MCP servers were deleted.Parse JSONC, keep sibling servers, and refuse garbage without writing.
Why
.vscode/mcp.jsonis edited as JSONC. That is valid for VS Code andinvalid for
JSON.parse. The old unit test called the wipe "graceful".Verification
githubserver lost that server on current main"not json {{{"leaves the file bytes unchangednpm run checkChecklist
git commit -snpm run checkand it passes