fix: resolve CodeQL and AI code quality findings#100
Merged
Conversation
- Remove unused path import in quickActions.test.ts (CodeQL) - Fix spelling: 'urls' to 'URLs' in test name (AI) - Add URL edge case tests: protocol-relative, query strings, fragments (AI) - Replace catch (err: any) with catch (err: unknown) + type guard (AI) - Use descriptive variable names in version comparison property test (AI) - Constrain exit code range to 0-255 in formatCliOutput property test (AI) Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves all 9 open findings from the GitHub code quality scanners (1 CodeQL standard + 8 AI).
Standard findings (CodeQL)
quickActions.test.ts:3pathAI findings
binary.test.ts:306binary.test.ts:700binary.test.ts:711//github.com/...rejection testdownloadIntegration.test.ts:203catch (err: any)bypasses type safetycatch (err: unknown)with type guardpropertyBased.test.ts:74ma, mi, pa, mb, mib, pbmajorA, minorA, patchA, majorB, minorB, patchBpropertyBased.test.ts:126fc.integer()produces unrealistic exit codes{ min: 0, max: 255 }Two AI findings were intentionally not changed:
2>/dev/nullsuppresses noisy openssl deprecation warnings in test output. Removing it adds noise without value.afterhook already restores the env var correctly; the AI suggestion duplicated the hook.Testing
222 tests pass (2 new). The 1 pre-existing MCP framing failure is unrelated.