feat: use GitHub App token for release-please identity separation#89
Merged
Conversation
Use patchloom-release App token for release-please so PRs are authored by patchloom-release[bot] instead of github-actions[bot]. This fixes the auto-approve self-approval deadlock (github-actions[bot] cannot approve its own PRs) and enables CI to trigger on release PR updates (GITHUB_TOKEN events are suppressed by GitHub). - Add create-github-app-token step in release.yml - Pass app token to release-please-action - Add patchloom-release[bot] to auto-approve trusted actors Closes #77 Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the
patchloom-releaseGitHub App token for release-please so PRsare authored by
patchloom-release[bot]instead ofgithub-actions[bot].Problem
github-actions[bot]cannot approve PRs it authored (self-approvaldeadlock on release-please PRs)
GITHUB_TOKENevents are suppressed by GitHub, so CI does nottrigger on release PR updates
Changes
actions/create-github-app-tokenstep togenerate an app token, pass it to
release-please-actionviatoken:patchloom-release[bot]to the trustedactor list so release PRs get auto-approved by
github-actions[bot]Setup completed
patchloom-releasecreated (App ID: 3978051)patchloom-vscoderepo onlyAPP_IDandAPP_PRIVATE_KEYstored as repo secretsCloses #77