Merged
Conversation
…ected Instead of crashing with exit(1) when no .domscribe/ directory exists, the MCP server now starts in dormant mode with a single diagnostic status tool. This prevents "failed" MCP server noise in agent sessions opened outside domscribe workspaces. - Add DormantStatusTool returning workspace status and setup guidance - Introduce discriminated union on McpAdapterOptions (active | dormant) - McpAdapter branches on mode: full tools+prompts vs diagnostic-only - Extract setupShutdownHandlers in mcp.command.ts to avoid duplication
|
View your CI Pipeline Execution ↗ for commit 1725b06
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exit(1)when no.domscribe/directory exists. Since the plugin is installed at user scope, this shows a "failed" MCP server in every agent session opened outside a domscribe workspace.domscribe.statusdiagnostic tool that explains the workspace isn't active and how to set it up.McpAdapterOptionsis now a discriminated union (active | dormant). The command orchestrator selects the mode; the adapter stays pure wiring.Changes
dormant-status.tool.tsDormantStatusTool— returns{ active: false, cwd, guidance }mcp-adapter.tsmcp.command.ts*.spec.tsTest plan
nx test domscribe-relay— 274 tests pass (including new dormant mode tests)nx lint domscribe-relay— cleannx typecheck domscribe-relay— cleannx build domscribe-relay— cleannpx domscribe mcpoutside a workspace — process stays alive,tools/listreturns 1 toolnpx domscribe mcpinside a workspace — all 12 tools + 4 prompts (no regression)