Skip to content

Always call completion blocks even when image fetched is nil #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Mar 12, 2014
Merged

Always call completion blocks even when image fetched is nil #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions FastImageCache/FICImageCache.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,12 +223,23 @@ - (BOOL)_retrieveImageForEntity:(id <FICEntity>)entity withFormatName:(NSString

- (void)_imageDidLoad:(UIImage *)image forURL:(NSURL *)URL {
NSDictionary *requestDictionary = [_requests objectForKey:URL];
if (image != nil && requestDictionary != nil) {
if (requestDictionary != nil) {
for (NSMutableDictionary *entityDictionary in [requestDictionary allValues]) {
id <FICEntity> entity = [entityDictionary objectForKey:FICImageCacheEntityKey];
NSString *formatName = [entityDictionary objectForKey:FICImageCacheFormatKey];
NSDictionary *completionBlocksDictionary = [entityDictionary objectForKey:FICImageCacheCompletionBlocksKey];
[self _processImage:image forEntity:entity withFormatName:formatName completionBlocksDictionary:completionBlocksDictionary];
if (image != nil){
[self _processImage:image forEntity:entity withFormatName:formatName completionBlocksDictionary:completionBlocksDictionary];
} else {
NSArray *completionBlocks = [completionBlocksDictionary objectForKey:formatName];
if (completionBlocks != nil) {
dispatch_async(dispatch_get_main_queue(), ^{
for (FICImageCacheCompletionBlock completionBlock in completionBlocks) {
completionBlock(entity, formatName, nil);
}
});
}
}
}
}

Expand Down