Create GH pages for PP example data#1
Merged
theosanderson merged 18 commits intomainfrom Aug 31, 2024
Merged
Conversation
theosanderson
force-pushed
the
Create-GH-pages-for-PP-example-data
branch
from
8cc2b9c to
38704d7
Compare
theosanderson
requested review from
chaoran-chen,
corneliusroemer and
emmahodcroft
Contributor
|
Nice, what about having astro pages in Pathoplexus overlay? And host sequences in public folder? And only show on demo.pathoplexus.org maybe to reduce risk of people using it on main page |
corneliusroemer
approved these changes
Aug 31, 2024
Contributor
corneliusroemer
left a comment
corneliusroemer
left a comment
There was a problem hiding this comment.
Great stuff, but see non-blocking comment about maybe just hosting these in overlay straight with the website.
Member
Author
|
👍 Thanks - happy for anyone to raise an issue about moving them to the website, that's not clearly better to me because then the demo site becomes different to the main site so I won't myself |
theosanderson
added a commit
to pathoplexus/pathoplexus
that referenced
this pull request
Aug 31, 2024
theosanderson
added a commit
to pathoplexus/pathoplexus
that referenced
this pull request
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves pathoplexus/pathoplexus#69 by yielding: https://pathoplexus.github.io/example_data/
Is this the best technical way to do this? No - but I think for applications like this it doesn't really matter?