Conversation
YohDeadfall
reviewed
Aug 8, 2025
| .last() | ||
| .expect("should not rebuild on empty node") | ||
| .aligned_size(); | ||
| self.length += UNSIZED_HEADER_LENGTH as usize; |
There was a problem hiding this comment.
Why are two operations instead of a single assignment?
| .expect("should not rebuild on empty node") | ||
| .aligned_size(); | ||
| self.length += UNSIZED_HEADER_LENGTH as usize; | ||
| for value in self.inner.iter() { |
There was a problem hiding this comment.
Why does the size contains the last item twice?
Collaborator
Author
There was a problem hiding this comment.
Node's id is stored separately. This unsized node logic is needed to mirror state of UnsizedPage in data bucket. And this page stores node id as one field, utility fields, slots and inner node values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.