Fix Clippy issues and move to new Rust edition

Cargo.toml

@@ -4,7 +4,7 @@ members = ["codegen", "examples", "performance_measurement", "performance_measur
 [package]
 name = "worktable"
 version = "0.5.4"
-edition = "2021"
+edition = "2024"
 authors = ["Handy-caT"]
 license = "MIT"
 repository = "https://github.com/pathscale/WorkTable"

codegen/Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "worktable_codegen"
 version = "0.5.4"
-edition = "2021"
+edition = "2024"
 license = "MIT"
 description = "WorkTable codegeneration crate"
 

codegen/src/persist_index/generator.rs

@@ -432,18 +432,20 @@ mod tests {
             }
         };
         let struct_ = Parser::parse_struct(input).unwrap();
-        let gen = Generator::new(struct_);
+        let generator = Generator::new(struct_);
 
         assert_eq!(
-            gen.field_types
+            generator
+                .field_types
                 .get(&Ident::new("test_idx", Span::call_site()))
                 .unwrap()
                 .to_string()
                 .as_str(),
             "i64"
         );
         assert_eq!(
-            gen.field_types
+            generator
+                .field_types
                 .get(&Ident::new("exchnage_idx", Span::call_site()))
                 .unwrap()
                 .to_string()

codegen/src/persist_index/mod.rs

@@ -10,12 +10,12 @@ mod space;
 
 pub fn expand(input: TokenStream) -> syn::Result<TokenStream> {
     let input_struct = Parser::parse_struct(input)?;
-    let mut gen = Generator::new(input_struct);
+    let mut generator = Generator::new(input_struct);
 
-    let type_def = gen.gen_persist_type()?;
-    let persistable_def = gen.gen_persistable_impl()?;
-    let impl_def = gen.gen_persist_impl()?;
-    let space_index = gen.gen_space_index();
+    let type_def = generator.gen_persist_type()?;
+    let persistable_def = generator.gen_persistable_impl()?;
+    let impl_def = generator.gen_persist_impl()?;
+    let space_index = generator.gen_space_index();
 
     Ok(quote! {
         #type_def

codegen/src/persist_table/mod.rs

@@ -14,16 +14,16 @@ pub fn expand(input: TokenStream) -> syn::Result<TokenStream> {
     let pk_ident = Parser::parse_pk_ident(&input_fn);
     let attributes = Parser::parse_attributes(&input_fn.attrs);
 
-    let gen = Generator {
+    let generator = Generator {
         struct_def: input_fn,
         pk_ident,
         attributes,
     };
 
-    let space_file_def = gen.gen_space_file_def();
-    let persistence_engine = gen.get_persistence_engine_type();
-    let persistence_task = gen.get_persistence_task_type();
-    let size_measurable_impl = gen.gen_size_measurable_impl()?;
+    let space_file_def = generator.gen_space_file_def();
+    let persistence_engine = generator.get_persistence_engine_type();
+    let persistence_task = generator.get_persistence_task_type();
+    let size_measurable_impl = generator.gen_size_measurable_impl()?;
 
     Ok(quote! {
         #size_measurable_impl

codegen/src/worktable/generator/primary_key.rs

@@ -112,10 +112,10 @@ impl Generator {
                     .get(i)
                     .expect("primary key column name always exists if in primary keys list");
 
-                let gen = Self::get_generator_from_type(type_, i)?;
+                let generator = Self::get_generator_from_type(type_, i)?;
                 quote! {
                     impl TablePrimaryKey for #ident {
-                        type Generator = #gen;
+                        type Generator = #generator;
                     }
                 }
             }

examples/src/main.rs

@@ -47,7 +47,7 @@ async fn main() {
         attr2: 345,
         test: 1,
         id: 0,
-        attr_float: 100.0.into(),
+        attr_float: 100.0,
         attr_string: "String_attr0".to_string(),
     };
 
@@ -58,7 +58,7 @@ async fn main() {
             attr2: 345 + i as i32,
             test: i as i32,
             id: i as u64,
-            attr_float: (100.0 + i as f64).into(),
+            attr_float: 100.0 + i as f64,
             attr_string: format!("String_attr{}", i),
         };
 

src/in_memory/pages.rs

@@ -282,10 +282,11 @@ where
         let page = pages
             .get(page_id_mapper(link.page_id.into()))
             .ok_or(ExecutionError::PageNotFound(link.page_id))?;
-        let gen_row = page
-            .get_mut_row_ref(link)
-            .map_err(ExecutionError::DataPageError)?
-            .unseal_unchecked();
+        let gen_row = unsafe {
+            page.get_mut_row_ref(link)
+                .map_err(ExecutionError::DataPageError)?
+                .unseal_unchecked()
+        };
         let res = op(gen_row);
         Ok(res)
     }
@@ -313,8 +314,10 @@ where
             .get(page_id_mapper(link.page_id.into()))
             .ok_or(ExecutionError::PageNotFound(link.page_id))?;
         let gen_row = <Row as StorableRow>::WrappedRow::from_inner(row);
-        page.save_row_by_link(&gen_row, link)
-            .map_err(ExecutionError::DataPageError)
+        unsafe {
+            page.save_row_by_link(&gen_row, link)
+                .map_err(ExecutionError::DataPageError)
+        }
     }
 
     pub fn delete(&self, link: Link) -> Result<(), ExecutionError> {

tests/persistence/sync/mod.rs

@@ -53,7 +53,7 @@ fn test_space_insert_sync() {
             let row = TestSyncRow {
                 another: 42,
                 non_unique: 0,
-                field: 0.234.into(),
+                field: 0.234,
                 id: table.get_next_pk().0,
             };
             table.insert(row.clone()).unwrap();
@@ -93,7 +93,7 @@ fn test_space_insert_many_sync() {
                     let row = TestSyncRow {
                         another: i,
                         non_unique: (i % 4) as u32,
-                        field: (i as f64 / 100.0).into(),
+                        field: i as f64 / 100.0,
                         id: table.get_next_pk().0,
                     };
                     table.insert(row.clone()).unwrap();
@@ -137,15 +137,15 @@ fn test_space_update_full_sync() {
             let row = TestSyncRow {
                 another: 42,
                 non_unique: 0,
-                field: 0.0.into(),
+                field: 0.0,
                 id: table.get_next_pk().0,
             };
             table.insert(row.clone()).unwrap();
             table
                 .update(TestSyncRow {
                     another: 13,
                     non_unique: 0,
-                    field: 0.0.into(),
+                    field: 0.0,
                     id: row.id,
                 })
                 .await
@@ -186,7 +186,7 @@ fn test_space_update_query_pk_sync() {
             let row = TestSyncRow {
                 another: 42,
                 non_unique: 0,
-                field: 0.0.into(),
+                field: 0.0,
                 id: table.get_next_pk().0,
             };
             table.insert(row.clone()).unwrap();
@@ -230,12 +230,12 @@ fn test_space_update_query_unique_sync() {
             let row = TestSyncRow {
                 another: 42,
                 non_unique: 0,
-                field: 0.0.into(),
+                field: 0.0,
                 id: table.get_next_pk().0,
             };
             table.insert(row.clone()).unwrap();
             table
-                .update_field_by_another(FieldByAnotherQuery { field: 1.0.into() }, 42)
+                .update_field_by_another(FieldByAnotherQuery { field: 1.0 }, 42)
                 .await
                 .unwrap();
             table.wait_for_ops().await;
@@ -274,7 +274,7 @@ fn test_space_update_query_non_unique_sync() {
             let row = TestSyncRow {
                 another: 42,
                 non_unique: 10,
-                field: 0.0.into(),
+                field: 0.0,
                 id: table.get_next_pk().0,
             };
             table.insert(row.clone()).unwrap();
@@ -315,7 +315,7 @@ fn test_space_delete_sync() {
             let row = TestSyncRow {
                 another: 42,
                 non_unique: 0,
-                field: 0.0.into(),
+                field: 0.0,
                 id: table.get_next_pk().0,
             };
             table.insert(row.clone()).unwrap();
@@ -355,7 +355,7 @@ fn test_space_delete_query_sync() {
             let row = TestSyncRow {
                 another: 42,
                 non_unique: 0,
-                field: 0.0.into(),
+                field: 0.0,
                 id: table.get_next_pk().0,
             };
             table.insert(row.clone()).unwrap();

tests/persistence/sync/string_primary_index.rs

@@ -52,7 +52,7 @@ fn test_space_insert_sync() {
             let row = TestSyncRow {
                 another: 42,
                 non_unique: 0,
-                field: 0.234.into(),
+                field: 0.234,
                 id: "Some string to test".to_string(),
             };
             table.insert(row.clone()).unwrap();
@@ -62,7 +62,6 @@ fn test_space_insert_sync() {
         {
             let table = TestSyncWorkTable::load_from_file(config).await.unwrap();
             assert!(table.select(pk.into()).is_some());
-            assert_eq!(table.0.pk_gen.get_state(), ())
         }
     });
 }
@@ -94,7 +93,7 @@ fn test_space_insert_many_sync() {
                     let row = TestSyncRow {
                         another: i,
                         non_unique: (i % 4) as u32,
-                        field: (i as f64 / 100.0).into(),
+                        field: i as f64 / 100.0,
                         id: format!("Some string to test number {}", i),
                     };
                     table.insert(row.clone()).unwrap();
@@ -110,7 +109,6 @@ fn test_space_insert_many_sync() {
             for pk in pks {
                 assert!(table.select(pk.into()).is_some());
             }
-            assert_eq!(table.0.pk_gen.get_state(), ())
         }
     });
 }
@@ -139,15 +137,15 @@ fn test_space_update_full_sync() {
             let row = TestSyncRow {
                 another: 42,
                 non_unique: 0,
-                field: 0.0.into(),
+                field: 0.0,
                 id: "Some string before".to_string(),
             };
             table.insert(row.clone()).unwrap();
             table
                 .update(TestSyncRow {
                     another: 13,
                     non_unique: 0,
-                    field: 0.0.into(),
+                    field: 0.0,
                     id: "Some string before".to_string(),
                 })
                 .await
@@ -159,7 +157,6 @@ fn test_space_update_full_sync() {
             let table = TestSyncWorkTable::load_from_file(config).await.unwrap();
             assert!(table.select(pk.clone().into()).is_some());
             assert_eq!(table.select(pk.into()).unwrap().another, 13);
-            assert_eq!(table.0.pk_gen.get_state(), ())
         }
     });
 }
@@ -188,7 +185,7 @@ fn test_space_update_query_pk_sync() {
             let row = TestSyncRow {
                 another: 42,
                 non_unique: 0,
-                field: 0.0.into(),
+                field: 0.0,
                 id: "Some string before".to_string(),
             };
             table.insert(row.clone()).unwrap();
@@ -203,7 +200,6 @@ fn test_space_update_query_pk_sync() {
             let table = TestSyncWorkTable::load_from_file(config).await.unwrap();
             assert!(table.select(pk.clone().into()).is_some());
             assert_eq!(table.select(pk.into()).unwrap().another, 13);
-            assert_eq!(table.0.pk_gen.get_state(), ())
         }
     });
 }
@@ -233,12 +229,12 @@ fn test_space_update_query_unique_sync() {
             let row = TestSyncRow {
                 another: 42,
                 non_unique: 0,
-                field: 0.0.into(),
+                field: 0.0,
                 id: "Some string before".to_string(),
             };
             table.insert(row.clone()).unwrap();
             table
-                .update_field_by_another(FieldByAnotherQuery { field: 1.0.into() }, 42)
+                .update_field_by_another(FieldByAnotherQuery { field: 1.0 }, 42)
                 .await
                 .unwrap();
             table.wait_for_ops().await;
@@ -248,7 +244,6 @@ fn test_space_update_query_unique_sync() {
             let table = TestSyncWorkTable::load_from_file(config).await.unwrap();
             assert!(table.select(pk.clone().into()).is_some());
             assert_eq!(table.select(pk.into()).unwrap().field, 1.0);
-            assert_eq!(table.0.pk_gen.get_state(), ())
         }
     });
 }
@@ -278,7 +273,7 @@ fn test_space_update_query_non_unique_sync() {
             let row = TestSyncRow {
                 another: 42,
                 non_unique: 10,
-                field: 0.0.into(),
+                field: 0.0,
                 id: "Some string before".to_string(),
             };
             table.insert(row.clone()).unwrap();
@@ -293,7 +288,6 @@ fn test_space_update_query_non_unique_sync() {
             let table = TestSyncWorkTable::load_from_file(config).await.unwrap();
             assert!(table.select(pk.clone().into()).is_some());
             assert_eq!(table.select(pk.into()).unwrap().another, 13);
-            assert_eq!(table.0.pk_gen.get_state(), ())
         }
     });
 }
@@ -322,7 +316,7 @@ fn test_space_delete_sync() {
             let row = TestSyncRow {
                 another: 42,
                 non_unique: 0,
-                field: 0.0.into(),
+                field: 0.0,
                 id: "Some string before".to_string(),
             };
             table.insert(row.clone()).unwrap();
@@ -333,7 +327,6 @@ fn test_space_delete_sync() {
         {
             let table = TestSyncWorkTable::load_from_file(config).await.unwrap();
             assert!(table.select(pk.into()).is_none());
-            assert_eq!(table.0.pk_gen.get_state(), ())
         }
     });
 }
@@ -362,7 +355,7 @@ fn test_space_delete_query_sync() {
             let row = TestSyncRow {
                 another: 42,
                 non_unique: 0,
-                field: 0.0.into(),
+                field: 0.0,
                 id: "Some string before".to_string(),
             };
             table.insert(row.clone()).unwrap();
@@ -373,7 +366,6 @@ fn test_space_delete_query_sync() {
         {
             let table = TestSyncWorkTable::load_from_file(config).await.unwrap();
             assert!(table.select(pk.into()).is_none());
-            assert_eq!(table.0.pk_gen.get_state(), ())
         }
     });
 }