Skip to content

Change heat generation units and name#12

Merged
DavidMStraub merged 2 commits into
pathsim:masterfrom
DavidMStraub:redefine_qdot
May 11, 2026
Merged

Change heat generation units and name#12
DavidMStraub merged 2 commits into
pathsim:masterfrom
DavidMStraub:redefine_qdot

Conversation

@DavidMStraub
Copy link
Copy Markdown
Collaborator

When creating a sim in PathView, I noticed two inconsistencies in the output of cell vs the input of the lumped thermal model block:

  1. the cell had Q_heat as output port name, the thermal model Q_dot as input
  2. the cell returned the volume averaged heating, the thermal model expected the total heating.

Both are named Q_dot now and are in Watts.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the PyBaMM cell blocks’ heat-generation output with the lumped thermal model by (1) standardizing the port name to Q_dot and (2) switching the reported quantity to total heat generation in Watts.

Changes:

  • Renamed cell heat output port from Q_heat to Q_dot across blocks and tests.
  • Switched PyBaMM output variable from volumetric heating (... [W.m-3]) to total heating (... [W]) and updated docstrings accordingly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
src/pathsim_batt/cells/pybamm_cell.py Renames heat output port to Q_dot and changes heat output variable/units to total heating in W.
tests/cells/test_pybamm_cell.py Updates tests to expect Q_dot instead of Q_heat in labels, comments, and assertions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/pathsim_batt/cells/pybamm_cell.py Outdated
Comment thread tests/cells/test_pybamm_cell.py Outdated
Comment thread tests/cells/test_pybamm_cell.py Outdated
Comment thread tests/cells/test_pybamm_cell.py Outdated
Comment thread tests/cells/test_pybamm_cell.py Outdated
Comment thread tests/cells/test_pybamm_cell.py
@DavidMStraub DavidMStraub merged commit e12badc into pathsim:master May 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants