Skip to content

change some default settings inline with what the golang default http#8

Merged
MFAshby merged 1 commit intomainfrom
increase_max_idle_connections
Feb 24, 2026
Merged

change some default settings inline with what the golang default http#8
MFAshby merged 1 commit intomainfrom
increase_max_idle_connections

Conversation

@MFAshby
Copy link
Copy Markdown
Contributor

@MFAshby MFAshby commented Feb 19, 2026

...client settings are

hoping to avoid some odd behaviour around idle connections

client settings are

hoping to avoid some odd behaviour around idle connections
Copy link
Copy Markdown
Contributor

@leonyork leonyork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not looked into if these are sensible numbers for the new transport settings you're using (apart from the testing you've done elsewhere), but/so I think it's worth making them configurable and setting the current values as the defaults.

Comment thread main.go
Comment on lines +340 to +341
TLSHandshakeTimeout: 10 * time.Second,
ExpectContinueTimeout: 1 * time.Second,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make these configurable as command line arguments (like the others), so that we can tune this without releasing a new version of regproxy?

Copy link
Copy Markdown
Contributor Author

@MFAshby MFAshby Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied and pasted these from the default configuration and possible I shouldn't have...

Both are irrelevant for our use case (test-control doesn't use TLS, nor does it use HTTP 100-continue responses.)

I could make them configurable for the convenience of others who might be using these features but it won't help us.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining. Approved.

@MFAshby MFAshby merged commit 3bcd4ac into main Feb 24, 2026
1 check passed
@MFAshby MFAshby deleted the increase_max_idle_connections branch February 24, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants