Integrate benchmarking#200
Merged
johannahaffner merged 16 commits intopatrick-kidger:devfrom Dec 27, 2025
Merged
Conversation
Collaborator
Author
|
Tests are failing due to JAX 0.8.2 being used with 3.12, and a different version of JAX being used with 3.10, for which JAX has recently dropped support. |
Owner
patrick-kidger
left a comment
There was a problem hiding this comment.
I think this looks reasonable to me, with only one comment, can we target dev instead of main?
99a1895 to
fb59329
Compare
added 16 commits
December 27, 2025 20:32
…luation of Optimistix' solvers.
… don't need them here. We would otherwise have to use context management for any comparison to Optax minimisers.
…nd, adapt to sif2jax usage of properties.
fb59329 to
9db0530
Compare
Collaborator
Author
|
Now failing checks because |
patrick-kidger
pushed a commit
that referenced
this pull request
Feb 8, 2026
* Implement pytest-benchmark based setup for systematic performance evaluation of Optimistix' solvers. * version bump for sif2jax requirements * add semi-recent matplotlib version to specify a minimum * no more monkeypatching * set EQX_ON_ERROR with os.environ * give a reason for skipping compilation tests * Add L-BFGS solvers to benchmark suite * clarify what --benchmark-autosave will do. * remove strict dtype promotion rules - benchmarks are not tests, so we don't need them here. We would otherwise have to use context management for any comparison to Optax minimisers. * state purpose of --scipy flag more clearly. * improve contribution guidelines, inline decorator, specify pyright errata * pyproject.toml from main * add sif2jax * move benchmark dependencies to tests group * add benchmark-skip option * add example to contributing guidelines, document OrderedDict workaround, adapt to sif2jax usage of properties. --------- Co-authored-by: Johanna Haffner <johanna.haffner@bsse.ethz.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on #128.
Two small things:
pytest-benchmark, and plotting is also something one would do every few runs, rather than every run - in particular whenever one would like to look at a comparison between solvers or implementation with others.pytest benchmarks --benchmark-only- if we'd put--benchmark-onlyintobenchmarks/conftest.pythen it would get collected whenpytestis invoked and it would override our default--benchmark-skip.And one weird thing: if I remove the
OrderedDict, I still get results jumbled between solvers. But as you (@patrick-kidger) note, it should not be needed. Playing with it for a bit I can remove it in two of the three places, but the underlying logic is not apparent to me, nor am I happy to trust that this would work for a different number of solvers / problems / something.I think the pragmatic thing to do here is to simply document the puzzling necessity of
OrderedDictin this script. (Low-key itching to check whether this is an upstream thing...)