Correct Checkstyle clause in docs #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Patrick,
Correct me if I'm wrong but it looks like
checkstyle:checkbinds to Maven'sverifyphase by default (docs). Thus it seems worth it to adjust the docs sincemvn testis not going to run Checkstyle.If
mvn testis indeed what you had in mind, guess you could change thecommon-parentPOM to bind Checkstyle to another phase but this could have ramifications in other projects only you are aware of as the POM maintainer.The purpose of this PR is just to attract attention to the wording in docs, feel free to discard it.