FD-238: Open source btcopilot#2
Merged
Merged
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 21808676 | Triggered | Generic Password | 42628dc | btcopilot/pro/tasks.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
patrickkidd
pushed a commit
that referenced
this pull request
Mar 8, 2026
- Defer production prompt loading to avoid import-time FileNotFoundError in Docker CI where fdserver is not co-located - Remove dead _BASE_SARF_REVIEW variable (review comment #1) - Extract error message to PROMPTS_UNAVAILABLE_ERROR constant shared between litreview.py and compare.py (review comment #2) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
patrickkidd
added a commit
that referenced
this pull request
Mar 8, 2026
- Defer production prompt loading to avoid import-time FileNotFoundError in Docker CI where fdserver is not co-located - Remove dead _BASE_SARF_REVIEW variable (review comment #1) - Extract error message to PROMPTS_UNAVAILABLE_ERROR constant shared between litreview.py and compare.py (review comment #2) Co-authored-by: Hurin <hurin@openclaw.ai> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
patrickkidd
added a commit
that referenced
this pull request
May 2, 2026
- apply_local_changes: refactored to two-phase form. Local edits now beat server-side deletes per item-level last-write-wins (per docstring). Added regression test `test_local_edit_beats_server_delete`. (Gemini #1) - reserve_id_block: hoisted `import PyQt5.sip` out of retry loop. Marked `# noqa: F401` since the import is for SIP registration side effects, not a name reference. (Gemini #2) - merge_scene_collection: removed entirely. Pre-release feature with no production callers — deprecation was over-cautious. Deleted the associated test file. (Patrick review comment) All apply_local_changes tests pass (16, incl. new regression case). Full schema + pro suites green, no regressions.
patrickkidd
added a commit
that referenced
this pull request
May 18, 2026
#1 _remap_person_refs no longer remaps PairBond person.parents nor the mixed-entity deltas.delete list with a person-id-only map. #2 _drop_committed_dup_pair_bonds remaps a dropped duplicate bond's child onto the surviving committed pair_bond instead of nulling it, preserving the parent-child link (_committed_dyads now dyad→pb-id). #4 _windowed_conversation: empty tail keeps the cursor marker/nonce so the model emits nothing rather than re-extracting the full thread. Tests updated to the new contracts; 59 personal/isolation tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
patrickkidd
added a commit
that referenced
this pull request
May 18, 2026
* FD-319: per-discussion re-extraction cursor + commit-pdp Adds discussions.extracted_through_order / pending_extracted_through_order, the _windowed_conversation cursor windowing with an unforgeable per-call nonce marker, the POST /personal/discussions/<id>/commit-pdp accept endpoint, the cursor Alembic migration, and prompt-idempotency work from the committed-duplicate induction runs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * FD-319: re-extraction cursor repairs + committed-data integrity - Empty-PDP "Accept all" is a valid full accept and advances the cursor (empty item_ids allowed only with full_accept). - fix_committed_person_duplicates iterated to a fixed point (fixes intermittent extraction 500 on real diagrams). - Validator: event person/spouse/child positive refs must be committed. - fix_unresolved_person_refs drops events/pair_bonds with unresolvable refs and clears orphaned parents; commit_pdp_items skips orphaned pair bonds; inferred bonds require resolvable people. - child_of (parent/offspring) F1 metric + dashboard; structural-completion pass evaluated and rejected (logged). - Tests: cursor + pdp/commit/isolation green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * FD-319: address PR #119 review (pdp ref remap + empty-tail cursor) #1 _remap_person_refs no longer remaps PairBond person.parents nor the mixed-entity deltas.delete list with a person-id-only map. #2 _drop_committed_dup_pair_bonds remaps a dropped duplicate bond's child onto the surviving committed pair_bond instead of nulling it, preserving the parent-child link (_committed_dyads now dyad→pb-id). #4 _windowed_conversation: empty tail keeps the cursor marker/nonce so the model emits nothing rather than re-extracting the full thread. Tests updated to the new contracts; 59 personal/isolation tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Patrick Stinson <patrick@alaskafamilysystems.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.