Skip to content

Conversation

@simonihmig
Copy link

  • Added modulePrefix to config to fix "undefined" component paths/classes
  • Added broccoli-debug to support debugging tree generation

I played around with your fork of ember-component-css (webark#294), which wasn't working initially. The main issue was that config.modulePrefix was undefined, causing undefined showing up in the path/class, and the runtime component not picking up the (wrongly) generated class name, thus no styles applied...

I don't know how this was supposed to work, but I added it in included and then it worked finally (when used together with your ember-cli PR ember-cli/ember-cli#8146)

Feel free to integrate this if you think it makes sense...

Thanks a bunch for working on this! 👍

Added broccoli-debug to support debugging tree generation
@patricklx
Copy link
Owner

patricklx commented Nov 10, 2018

Hi, thanks! I hope they look at the PR in ember-cli... Will try ti ping them in discord, let's see...

I thought modulePrefix is always defined in the app config?

Mmm, is broccoli-debug always enabled?
If it is, then if you can remove it i merge this :)

@simonihmig
Copy link
Author

I thought modulePrefix is always defined in the app config?

Probably it is, but you were passing this.addonConfig to the lib/ helpers, that's why it was missing for me. I simply put it into the addon config here, but again not sure how you intended it to be...

Mmm, is broccoli-debug always enabled?

No, it only gets activated when the matching environment variable is set. From the docs

Supports leaving debug trees in the build with minimal cost when not being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants