Locale switcher for interface and all translated contents. #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get the default locale from the Omeka site settings, not Zend_Locale::getDefault(), which always returns 'en'. Added upgrade hook to change all instances of the default locale code 'en' to the real default locale. This required a version bump to version 1.1.
This is no longer necessary now that the ExperimentalBeijing plugin adds translations to the search texts and can use those to do searches for items/browse as well. This will reduce the maintenance burden of the fork, as all it needs to handle is getting the lang parameter from $_GET and properly get the default locale. We may want to see if we can at least get the latter merged upstream.
This reverts commits back through "Note that this is a fork in README" 33fa1b6.
Contributor
Author
|
The main issue is for the elements of the contents (Dublin Core title, etc.) still don't have a language value, like in Omeka S. It may be a future improvement. |
Owner
|
Many thanks, and sorry for the delay in merging. It's worth noting that I'm moving on to a new gig, and so I'm not sure how much time I'll be able to devote to my Omeka side-projects. If it makes sense to you to work from your fork, that makes sense to me. |
Contributor
Author
|
I don't develop anymore on Omeka Classic, but somebody asked me to improve the plugin for an old project. There are still one or two commits to do, then I won't develop any fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merge of previous pull requests, with a full integration, so the visitor can choose the language he wants for any pages.