New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale switcher for interface and all translated contents. #11

Merged
merged 42 commits into from Aug 1, 2018

Conversation

Projects
None yet
3 participants
@Daniel-KM
Contributor

Daniel-KM commented Jul 10, 2018

This is a merge of previous pull requests, with a full integration, so the visitor can choose the language he wants for any pages.

zploskey and others added some commits Nov 30, 2016

v1.1, real default locale, items search support
Get the default locale from the Omeka site settings,
not Zend_Locale::getDefault(), which always returns 'en'.
Added upgrade hook to change all instances of the default locale
code 'en' to the real default locale. This required a version bump
to version 1.1.
Remove hookItemsBrowseSql
This is no longer necessary now that the ExperimentalBeijing plugin
adds translations to the search texts and can use those to do searches
for items/browse as well. This will reduce the maintenance burden of the
fork, as all it needs to handle is getting the lang parameter from $_GET
and properly get the default locale. We may want to see if we can at
least get the latter merged upstream.
Revert changes from upstream except locale switch
This reverts commits back through "Note that this is a fork in README"
33fa1b6.
@Daniel-KM

This comment has been minimized.

Contributor

Daniel-KM commented Jul 10, 2018

The main issue is for the elements of the contents (Dublin Core title, etc.) still don't have a language value, like in Omeka S. It may be a future improvement.

@Daniel-KM Daniel-KM referenced this pull request Jul 10, 2018

Open

Feature/locale admin #1

@patrickmj

This comment has been minimized.

Owner

patrickmj commented Aug 1, 2018

Many thanks, and sorry for the delay in merging.

It's worth noting that I'm moving on to a new gig, and so I'm not sure how much time I'll be able to devote to my Omeka side-projects. If it makes sense to you to work from your fork, that makes sense to me.

@patrickmj patrickmj closed this Aug 1, 2018

@patrickmj patrickmj reopened this Aug 1, 2018

@patrickmj patrickmj merged commit 5b42e3b into patrickmj:master Aug 1, 2018

@Daniel-KM Daniel-KM deleted the Daniel-KM:feature/merge branch Aug 1, 2018

@Daniel-KM

This comment has been minimized.

Contributor

Daniel-KM commented Aug 1, 2018

I don't develop anymore on Omeka Classic, but somebody asked me to improve the plugin for an old project. There are still one or two commits to do, then I won't develop any fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment