Fix locale code matching / 2 char locales #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug introduced in 1c7b373 set a 2 character locale when the browser requested a 4 character locale that had translations available. This resulted in translations failing to be displayed. This change makes us only fall back to trying to match the first two characters of the locale if the 4 char locale was not found. Furthermore, it sets the locale to whatever the application calls that locale, and not the two character locale which may not have a translation available.
zploskey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug introduced in 1c7b373 (see issue #4 ) set a 2 character locale
when the browser requested a 4 character locale that had
translations available. This resulted in translations failing
to be displayed. This change makes us only fall back to trying
to match the first two characters of the locale if the 4 char
locale was not found. Furthermore, it sets the locale to whatever
the application calls that locale, and not the two character
locale which may not have a translation available.