Add skill for PF issue creation#15
Conversation
272334a to
7bf51c2
Compare
jpuzz0
left a comment
There was a problem hiding this comment.
Some minor comments. Overall looks good & thanks for the demo yesterday!
| @@ -0,0 +1,714 @@ | |||
| --- | |||
There was a problem hiding this comment.
At 714 lines this exceeds the 500-line hard limit from Claude Code docs (longer skills consume more of the AI's context window, leaving less room for the actual task)— could the repo mapping tables, synonym lists, and template-handling details be extracted into reference files (e.g., reference/repo-map.md) to bring this under the limit?
There was a problem hiding this comment.
Ah yeah I have some local updates that trims it down to ~200 lines
|
|
||
| ## Workflow | ||
|
|
||
| ### 1. Detect PatternFly Repository Context |
There was a problem hiding this comment.
nit: Throughout the skill there are sections that prescribe exact bash commands, conditional trees, and scoring rubrics (e.g., here and the "Check for Similar Issues" section) — would it work to describe the desired behavior and let the AI figure out the implementation? That would also help bring the line count down.
| @@ -0,0 +1,511 @@ | |||
| # PatternFly Issue Skill - Usage Examples | |||
There was a problem hiding this comment.
nit: At 511 lines of scripted conversations, this is longer than the SKILL.md hard limit itself — would 2-3 short examples (one new issue, one followup) at ~50 lines total be enough to demonstrate the expected interaction pattern?
| @@ -0,0 +1,32 @@ | |||
| --- | |||
There was a problem hiding this comment.
Does this template add value beyond what the SKILL.md instructions already describe for the blank-issue flow? The skill already walks through gathering title, description, and acceptance criteria.
7bf51c2 to
b99f903
Compare
|
Upon asking claude for other example skills that would fit into the new pf-workflow plugin I added: Show example skillsCould you first give some more examples of what skills would fit into this plugin? :black_circle_for_record: Great question! Here are potential skills for pf-workflow: Issue & PR Management pf-issue (current) pr-description pr-review-checklist backport Release & Documentation changelog-entry release-notes migration-guide Cross-Repo Coordination sync-check dependency-check Contributor Workflows good-first-issue triage pr-status And asking for examples of what a pf-workflow agent could be used for: Show agent examplesGreat question! Here's how I'd separate agent knowledge from skill tasks: pf-workflow Agent (foundational knowledge) The agent would contain knowledge that makes every workflow task better: 1. PatternFly Repository Ecosystem - All PatternFly repos and what they contain 2. Issue & PR Conventions - Formatting standards (always apply these): 3. Release & Versioning - Version numbering scheme (v5, v6, v6-alpha, etc.) 4. Cross-Repo Coordination Best Practices - When to create followup issues vs doing everything in one PR 5. Contributor Workflows - Issue lifecycle: triage → assign → implement → test → close Skills vs Agent: What Lives Where? Agent knows (general knowledge): Skills do (specific tasks): Example of how they work together: When you invoke /pf-issue: Litmus test: Does this separation make sense? The agent is the "PatternFly workflow handbook" that's always active, while skills |
plugins/pf-workflow/README.md
Outdated
| /plugin list # Verify plugin is installed | ||
| /plugin install pf-react@ai-helpers # Reinstall if needed |
There was a problem hiding this comment.
I think this is "pf-workflow@ai-helpers" instead.
jpuzz0
left a comment
There was a problem hiding this comment.
After this is addressed - https://github.com/patternfly/ai-helpers/pull/15/changes#r2966181200 - good to go. Thanks Eric!
Towards #16
You can view patternfly/patternfly-react#12277 to see an example of what the skill did - I called the skill from my local pattenfly clone while checked out on the feature branch, so the skill was able to comb through my commit history and call out the to-dos in React.
Here's an excerpt of the conversation I had with Claude to create the above react issue:
Show Claude conversation