Skip to content

Add skill for PF issue creation#15

Merged
jpuzz0 merged 7 commits intopatternfly:mainfrom
thatblindgeye:pf-issue-skill
Mar 20, 2026
Merged

Add skill for PF issue creation#15
jpuzz0 merged 7 commits intopatternfly:mainfrom
thatblindgeye:pf-issue-skill

Conversation

@thatblindgeye
Copy link
Contributor

@thatblindgeye thatblindgeye commented Mar 17, 2026

Towards #16

You can view patternfly/patternfly-react#12277 to see an example of what the skill did - I called the skill from my local pattenfly clone while checked out on the feature branch, so the skill was able to comb through my commit history and call out the to-dos in React.

Here's an excerpt of the conversation I had with Claude to create the above react issue:

Show Claude conversation
/pf-issue followwup patternfly-react  

I'll help you create a followup issue for patternfly-react. Let me start by checking the current repository context.

⏺ Bash(git remote get-url origin 2>/dev/null)
  ⎿  git@github.com:thatblindgeye/patternfly.git

⏺ Great! You're in the patternfly repository (branch: iss8106_wizardGlass), and you want to create a followup issue for
   patternfly-react.

  Before I proceed, how would you like to determine the followup work needed?

  1. Provide it yourself - You'll describe what needs to be done in patternfly-react
  2. Analyze commit history - I'll review your commits on this branch to suggest followup work

  Which option would you prefer?

❯ 2                                                                                                                    

⏺ Bash(git symbolic-ref refs/remotes/origin/HEAD 2>/dev/null | sed 's@^refs/remotes/origin/@@' || echo "main")
  ⎿  main

⏺ Bash(git log main..HEAD --oneline --no-decorate)
  ⎿  f00ad42c2 Updated new example name
     935dd25c6 Updated tokens and var naming
     0db26caf6 Spelling error
     … +4 lines (ctrl+o to expand)

⏺ Bash(git log main..HEAD --format="%h %s%n%b%n---")
  ⎿  f00ad42c2 Updated new example name

     ---
     … +18 lines (ctrl+o to expand)

⏺ Bash(git diff main...HEAD --stat)
  ⎿   .../components/Wizard/examples/Wizard.md           | 77 ++++++++++++++++++++++
      src/patternfly/components/Wizard/wizard.scss       | 24 ++++++-
      2 files changed, 99 insertions(+), 2 deletions(-)

⏺ Bash(git diff main...HEAD --name-only)
  ⎿  src/patternfly/components/Wizard/examples/Wizard.md
     src/patternfly/components/Wizard/wizard.scss

⏺ Let me examine the actual changes to understand what needs to be followed up in patternfly-react.

⏺ Bash(git diff main...HEAD -- src/patternfly/components/Wizard/wizard.scss)
  ⎿  diff --git a/src/patternfly/components/Wizard/wizard.scss b/src/patternfly/components/Wizard/wizard.scss
     index d964bc3a5..2828b06c6 100644
     --- a/src/patternfly/components/Wizard/wizard.scss
     … +44 lines (ctrl+o to expand)

⏺ Bash(git diff main...HEAD -- src/patternfly/components/Wizard/examples/Wizard.md)
  ⎿  diff --git a/src/patternfly/components/Wizard/examples/Wizard.md b/src/patternfly/components/Wizard/examples/
     Wizard.md
     index 27216a653..5f09390b5 100644
     … +36 lines (ctrl+o to expand)

⏺ Perfect! I've analyzed the commits. Here's what I found:

  Changes in patternfly (current branch):
  - Added plain styling (transparent background) for Wizard components
  - New CSS variables for plain modifier: --pf-m-plain__header--BackgroundColor, --pf-m-plain__toggle--BackgroundColor,
   etc.
  - Updated border radius token for nav links
  - Auto-applies plain styling when glass theme is enabled (unless .pf-m-no-plain is used)
  - Added new "Plain" example in documentation
  - Added .pf-m-plain and .pf-m-no-plain modifiers to docs

  Suggested followup work for patternfly-react:

  Based on these changes, the React Wizard component will need:

  - Add isPlain prop to Wizard component to apply .pf-m-plain modifier
  - Add isNoPlain prop to Wizard component to apply .pf-m-no-plain modifier (to prevent auto-plain styling with glass
  theme)
  - Create a new "Plain" example/demo matching the HTML example added in patternfly
  - Update component tests if needed
  - Update TypeScript types for new props

  Does this look correct, or would you like to add/modify any of these followup items?

✻ Churned for 36s

❯ It looks good                                                                                                        

⏺ Great! Now let me try to auto-detect the PR URL for this branch using GitHub CLI.

⏺ Bash(gh auth status 2>&1)
  ⎿  Error: Exit code 1
     You are not logged into any GitHub hosts. To log in, run: gh auth login

⏺ GitHub CLI is not authenticated. Do you have a PR URL in the patternfly repo to reference for this followup work, or
  should I reference the branch name and commits instead?

❯ https://github.com/patternfly/patternfly/pull/8215                                                                   

⏺ Perfect! Now let me check for similar issues in patternfly-react. Since GitHub CLI is not authenticated, I'll save
  the issue to a file instead.

  Let me create the followup issue content:

⏺ Bash(date +%Y%m%d-%H%M%S)
  ⎿  20260317-104851

⏺ Where would you like to save the issue file?

  Default: ~/Desktop/patternfly-react-issue-20260317-104851.md

  Press Enter to use the default, or provide a different path.

❯ yes                                                                                                                  

⏺ Write(~/Desktop/patternfly-react-issue-20260317-104851.md)
  ⎿  Wrote 36 lines to ../../../Desktop/patternfly-react-issue-20260317-104851.md
     # Issue for patternfly/patternfly-react

     **Title:** Followup: Add plain styling support to Wizard component

     **Labels:** enhancement

     **Body:**

     ## Context

     … +26 lines (ctrl+o to expand)

⏺ Perfect! I've saved the followup issue to your Desktop at:

  ~/Desktop/patternfly-react-issue-20260317-104851.md

  The issue includes:
  - Reference to the patternfly PR #8215
  - Summary of the changes made in patternfly (plain styling, new CSS variables, glass theme support)
  - Checklist of followup work needed in patternfly-react (props, examples, tests, types)

  You can now create the issue manually at https://github.com/patternfly/patternfly-react/issues/new by copying the
  content from the file.

Copy link
Collaborator

@jpuzz0 jpuzz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. Overall looks good & thanks for the demo yesterday!

@@ -0,0 +1,714 @@
---
Copy link
Collaborator

@jpuzz0 jpuzz0 Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At 714 lines this exceeds the 500-line hard limit from Claude Code docs (longer skills consume more of the AI's context window, leaving less room for the actual task)— could the repo mapping tables, synonym lists, and template-handling details be extracted into reference files (e.g., reference/repo-map.md) to bring this under the limit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah I have some local updates that trims it down to ~200 lines


## Workflow

### 1. Detect PatternFly Repository Context
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Throughout the skill there are sections that prescribe exact bash commands, conditional trees, and scoring rubrics (e.g., here and the "Check for Similar Issues" section) — would it work to describe the desired behavior and let the AI figure out the implementation? That would also help bring the line count down.

@@ -0,0 +1,511 @@
# PatternFly Issue Skill - Usage Examples
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: At 511 lines of scripted conversations, this is longer than the SKILL.md hard limit itself — would 2-3 short examples (one new issue, one followup) at ~50 lines total be enough to demonstrate the expected interaction pattern?

@@ -0,0 +1,32 @@
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this template add value beyond what the SKILL.md instructions already describe for the blank-issue flow? The skill already walks through gathering title, description, and acceptance criteria.

@thatblindgeye
Copy link
Contributor Author

Upon asking claude for other example skills that would fit into the new pf-workflow plugin I added:

Show example skills

Could you first give some more examples of what skills would fit into this plugin?

:black_circle_for_record: Great question! Here are potential skills for pf-workflow:

  Issue & PR Management

  pf-issue (current)
  - Create GitHub issues with templates, followup tracking, duplicate detection

  pr-description
  - Generate PR descriptions from git diffs
  - Follow PatternFly PR template format
  - Extract relevant commits, breaking changes, migration notes

  pr-review-checklist
  - Generate review checklist based on changed files
  - Checks: "Did CSS changes include React updates?", "Do token changes have migration guide?", "Are new components
  added to docs?"

  backport
  - Identify commits that need backporting to maintenance branches
  - Check if changes apply to v5, v6-alpha, etc.
  - Generate backport issue with commit list

  Release & Documentation

  changelog-entry
  - Generate changelog entries from commits
  - Categorize: Breaking, Enhancement, Bug Fix, Documentation
  - Follow PatternFly changelog format

  release-notes
  - Generate release notes from milestone or version tag
  - Group by category, highlight breaking changes
  - Include migration guidance

  migration-guide
  - Generate migration guide from breaking changes
  - Create before/after code examples
  - Suggest codemods

  Cross-Repo Coordination

  sync-check
  - Check if changes in one repo need followup in others
  - Similar to pf-issue followup detection but for verification
  - "Did patternfly changes get reflected in patternfly-react?"

  dependency-check
  - When patternfly releases, check which repos need version bumps
  - Generate issues for patternfly-org, react-component-groups, etc.

  Contributor Workflows

  good-first-issue
  - Identify potential "good first issue" candidates from open issues
  - Suggest how to scope/break down larger issues

  triage
  - Help triage new issues: suggest labels, assign to correct repo
  - Check if bug report has required info

  pr-status
  - Check PR status across repos (CI, reviews, merge conflicts)
  - Generate status report

And asking for examples of what a pf-workflow agent could be used for:

Show agent examples

Great question! Here's how I'd separate agent knowledge from skill tasks:

  pf-workflow Agent (foundational knowledge)

  The agent would contain knowledge that makes every workflow task better:

  1. PatternFly Repository Ecosystem

  - All PatternFly repos and what they contain
  - Repository dependencies and relationships:
  design-tokens → patternfly (HTML/CSS) → patternfly-react → patternfly-org
                                        :arrow_lower_right: react-component-groups
  - Typical cross-repo workflows and coordination patterns

  2. Issue & PR Conventions

  - Formatting standards (always apply these):
    - Issue titles: Bug - [description], [Component] - [description]
    - PR titles: Similar format, semantic commit style
    - Description structure and required sections
  - Label taxonomy: What labels mean across repos (bug, enhancement, breaking-change, etc.)
  - When to use which template: Bug vs Feature vs Design Handoff vs Tech Debt

  3. Release & Versioning

  - Version numbering scheme (v5, v6, v6-alpha, etc.)
  - What branches exist and their purposes (main, v5, v6-prerelease)
  - Breaking change policies and migration requirements
  - Changelog format and conventions

  4. Cross-Repo Coordination Best Practices

  - When to create followup issues vs doing everything in one PR
  - How to reference work across repos (linking PRs, issues)
  - Communication patterns: Where to discuss, who to notify, when to coordinate

  5. Contributor Workflows

  - Issue lifecycle: triage → assign → implement → test → close
  - PR workflow: draft → review → revisions → approval → merge
  - Good citizen practices: keeping issues updated, linking related work, cleaning up stale items

  Skills vs Agent: What Lives Where?

  Agent knows (general knowledge):
  - "PatternFly uses Bug -  prefix for bug issues"
  - "CSS changes in patternfly usually need React followup in patternfly-react"
  - "Breaking changes require migration guides"

  Skills do (specific tasks):
  - pf-issue: Actually create the issue with correct format
  - pr-description: Actually generate the PR description
  - changelog-entry: Actually write the changelog entry

  Example of how they work together:

  When you invoke /pf-issue:
  1. Agent knowledge is automatically loaded: "Bug issues need Bug -  prefix, Select issues should check Menu/Popper
  for similar issues"
  2. Skill executes the task: Asks questions, searches for templates, checks duplicates, creates the issue
  3. Agent makes skill better: The skill's output follows conventions without the skill needing to specify every detail

  Litmus test:
  - "Always check for similar issues before creating new ones" → Agent (best practice for all issue work)
  - "Search for issues using component relationships" → Skill (specific task in pf-issue)
  - "Bug issues use Bug -  prefix" → Agent (convention that applies everywhere)
  - "Pre-populate issue title from context" → Skill (specific behavior of pf-issue)

  Does this separation make sense? The agent is the "PatternFly workflow handbook" that's always active, while skills
  are the "doers" that use that knowledge.

Comment on lines +25 to +26
/plugin list # Verify plugin is installed
/plugin install pf-react@ai-helpers # Reinstall if needed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is "pf-workflow@ai-helpers" instead.

Copy link
Collaborator

@jpuzz0 jpuzz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this is addressed - https://github.com/patternfly/ai-helpers/pull/15/changes#r2966181200 - good to go. Thanks Eric!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants