Have to tap pf-sort dropdown twice on iOS

[spadgett]

Mobile Safari will treat the first tap as a hover and only open the dropdown on the second tap. Also the tooltip overlays the dropdown items.

/cc @jwforres @rhamilto

[rhamilto]

Also the tooltip overlays the dropdown items.

So it sounds like we need to request the Angular-PatternFly directive has a tooltip position option?

[spadgett]

Also the tooltip overlays the dropdown items.

I can reproduce on a desktop as well.

So it sounds like we need to request the Angular-PatternFly directive has a tooltip position option?

Tooltips don't work well on mobile, particularly on buttons. If the dropdown is confusing, does it deserve a label instead?

[benjaminapetersen]

IMHO, i'd rather there be a label "sort by: <dropdown>"

[benjaminapetersen]

So a "tooltip position" option may not be necessary, since the dropdown drops down & there are controls to left and right, prob the position should just be top?

Otherwise, if I were going to control it I'd want something like:

<!-- no tooltip -->
<pf-sort
 config="config"></pf-sort>

<!-- default tooltip (top) -->
 <pf-sort
  config="config"
  sortby-tooltip></pf-sort>

<!-- positioned tooltip -->
 <pf-sort
  config="config"
  sortby-tooltip="left"></pf-sort>

If its added to a div instead of as a standalone node, I suppose it should be namespaced so it doesn't clash with other directives on the node:

 <div
  pf-sort
  pf-sort-config="config"
  pf-sort-sortby-tooltip="left"></div>

The config attr could possibly be collapsed into <div pf-sort="config">, that would also follow some common conventions, but is tangental.

[benjaminapetersen]

Files to fix for reference: https://github.com/patternfly/angular-patternfly/tree/master/src/sort
@MarkDeMaria

[spadgett]

Positioning the tooltip elsewhere doesn't fix the iOS problem where you have to tap twice.

@ajacobs21e Suggested removing the tooltip altogether, which I think is a better solution.

[benjaminapetersen]

True, and thats prob the most bothersome.
Sounds good!