Remove href="#" from html A tags to avoid unwanted redirections #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will the |
Member
|
LGTM |
Member
Author
|
Ugh, @waldenraines you are correct, we lost the pointer. I will fix it. |
Member
Author
|
Add CSS to put back missing pointer cursors |
There was a problem hiding this comment.
Thoughts about making an <a> always have cursor: pointer; not just within the toolbar?
Member
Author
|
I'm hesitant to make that broad of a stroke. |
Yeah, I hear ya, but I wonder if there is any valid reason to use an I won't hold this PR up on this comment but it may be something to revisit if we find ourselves having to do this elsewhere. LGTM |
|
@jeff-phillips-18 this will need a rebase now because I just merged #100, sorry about that. |
jeff-phillips-18
force-pushed
the
fixes
branch
from
e878466 to
b0dd2a6
Compare
Member
Author
|
Rebased and squashed |
waldenraines
pushed a commit
that referenced
this pull request
Sep 25, 2015
Remove href="#" from html A tags to avoid unwanted redirections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using href="#" causes a redirect when html5mode is on.
Using href="" causes a redirect when html5mode is off.
Removing it completely doesn't cause a redirect in either case.