Restores Build Package Update from Release #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtaylor113
approved these changes
Aug 8, 2017
Member
dtaylor113
left a comment
dtaylor113
left a comment
There was a problem hiding this comment.
What happened? We changed this previously in https://github.com/patternfly/angular-patternfly/pull/553/files
Member
Author
|
Dunno, I remember it but now the change just isn't there |
Member
|
It got updated by patternfly-build. Will this re-occur? |
Member
Author
Indeed, this will probably happen again since the release scripts are trying to increment the version and we're customizing it... might need an exception where if it sees anything in addition to version number it ignores it. That being said this may be a non-issue by incrementing to the latest version, with little bit more testing. Based on everything this PR, as is, provides an immediate fix, not something long-term. |
cdcabrera
changed the title
-eng repo version
cdcabrera
force-pushed
the
build-packageupdate
branch
from
28a8d74 to
e45b940
Compare
cdcabrera
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corrects current build fail due to incorrect "-eng" repo version... switches back from an exact NPM package version to a ">=" version.
PR Checklist