feat(TableMessage): Add support for PatternFly tables#425
feat(TableMessage): Add support for PatternFly tables#425nicolethoen merged 5 commits intopatternfly:mainfrom
Conversation
|
Preview: https://chatbot-pr-chatbot-425.surge.sh A11y report: https://chatbot-pr-chatbot-425-a11y.surge.sh |
rebeccaalpert
force-pushed
the
tables
branch
2 times, most recently
from
e62c8ac to
73435c1
Compare
rebeccaalpert
force-pushed
the
tables
branch
2 times, most recently
from
28aef09 to
9fc7519
Compare
edonehoo
left a comment
edonehoo
left a comment
There was a problem hiding this comment.
some suggestions for the table content!
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/BotMessage.tsx
Outdated
Show resolved
Hide resolved
…mples/Messages/BotMessage.tsx Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
In addition to the file comments below, a non-blocker for this PR would be switching from radio buttons for these examples and using a Select instead -- would reduce the space taken up, but would also allow more unique labeling for the Selects (right now there's basically 2+ radio buttons with the same labels on the page: 2 for "Table" etc). Again non-blocking here if we wanted to open a followup for a docs update.
|
Opening #433 for Select switch. |
rebeccaalpert
force-pushed
the
tables
branch
from
d3477d4 to
23962de
Compare
|
🎉 This PR is included in version 2.2.0-prerelease.21 🎉 The release is available on: Your semantic-release bot 📦🚀 |
6 participants
Wire Message to re-route tables to PF tables.
These are just basic tables, with no bells and whistles. I am defaulting to the mobile breakpoint, but we could also do a regular table at certain widths. Let me know what you want to do here - I am just copying Figma right now. I am also letting this be full width, but it will resize down if you change the device viewport or screen size - let me know if that's not what we want.
I am defining a default aria label, allowing passage of aria-labels, and also attempting to generate these based on headers. I have written tests for full tables, blank tables, headerless tables, cell-less tables, 1 column-tables, and 1-cell tables. Let me know if you can break this and we'll add another test.
Doc changes: