-
Notifications
You must be signed in to change notification settings - Fork 34
chore(React19): Enable React 19 #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview: https://chatbot-pr-chatbot-533.surge.sh A11y report: https://chatbot-pr-chatbot-533-a11y.surge.sh |
a8363d5 to
29be254
Compare
|
Just rebased. |
|
Rebased. |
kmcfaul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused about the MouseEvent params (previously we specified React.MouseEvent and native MouseEvent, and with the codemods now it only uses react's import of MouseEvent, losing the native one). Not sure if we still need to cover both explicitly or not.
Another general note is that I'm wondering if we want to keep the React.X notation on prop definitions for our docs. I don't think the build complains about having it there (still leaving out the overall react import), and I've noticed we still have it in the react-core's props. It may not be a big deal to leave this as is with the types imported, as it's usually pretty evident it's a react type for things like ReactNode.
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/AttachmentEdit.tsx
Outdated
Show resolved
Hide resolved
...s/module/patternfly-docs/content/extensions/chatbot/examples/Messages/MessageWithSources.tsx
Show resolved
Hide resolved
...es/module/patternfly-docs/content/extensions/chatbot/examples/Messages/PreviewAttachment.tsx
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/AttachmentEdit.tsx
Show resolved
Hide resolved
|
Addressed comments and rebased! |
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to remove these from the devDeps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Katie asked me to put them back in in the other package.json...do we need both?
|
🎉 This PR is included in version 6.3.0-prerelease.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
npx codemod react/update-react-imports --target ./packages/modulenpx prettier --write packages/moduleTesting: