Skip to content

feat(demo): Demo for drawer mode with display mode switcher #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rebeccaalpert merged 6 commits into from
Jul 28, 2025
Merged

feat(demo): Demo for drawer mode with display mode switcher #601

rebeccaalpert merged 6 commits into from
Jul 28, 2025

Conversation

@parthivrh
Copy link
Contributor

@parthivrh parthivrh commented Jul 10, 2025 •
edited
Loading

Created a chatbot demo to show off the drawer mode with display mode switcher. Closes #508

@patternfly-build
Copy link

patternfly-build commented Jul 10, 2025 •
edited
Loading

Preview: https://chatbot-pr-chatbot-601.surge.sh

A11y report: https://chatbot-pr-chatbot-601-a11y.surge.sh

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Jul 10, 2025

Docs: https://chatbot-pr-chatbot-601.surge.sh/patternfly-ai/chatbot/overview/demo#display-mode-chatbot
Demo: https://chatbot-pr-chatbot-601.surge.sh/patternfly-ai/chatbot/overview/demo/display-mode-chatbot/

rebeccaalpert
rebeccaalpert suggested changes Jul 10, 2025
View reviewed changes
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me. There's two areas where I think we could improve a little bit (skip to content focus and unneeded drawer action), and one area I'd like to carve out into a separate issue (maintaining dropdown focus when container is changed). I left more detailed comments below, but please ping me if you have any questions!

edonehoo
edonehoo suggested changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few small suggestions, but generally this looks great!

@edonehoo
Copy link
Contributor

edonehoo commented Jul 14, 2025

Like Rebecca mentioned, we changed our terminology from "docked" to "drawer", but I'm realizing that we may need to go back at update the display options menu at a global level (rather than just in this pr) @rebeccaalpert ?

Should we say "drawer" instead of "dock to window" for the menu item, since we're not using the term "docked" in our docs anymore
image

kaylachumley
kaylachumley approved these changes Jul 14, 2025
View reviewed changes
Copy link

@kaylachumley kaylachumley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on erin and rebeccas comments - design looks good! ty!

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Jul 15, 2025

@edonehoo - It's not a global change. We can definitely update the wording in this one specific demo if you want it to be "Drawer." We haven't deprecated the other mode or removed it from other demos.

@edonehoo
Copy link
Contributor

edonehoo commented Jul 15, 2025

@rebeccaalpert ahh okay thanks for clarifying! In that case, then yeah I think for this demo at least let's go with Drawer

@rebeccaalpert rebeccaalpert requested a review from edonehoo July 15, 2025 19:05
rebeccaalpert
rebeccaalpert reviewed Jul 15, 2025
View reviewed changes
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for making all those changes! I just have one comment about this one unused case.

rebeccaalpert
rebeccaalpert approved these changes Jul 15, 2025
View reviewed changes
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thank you so much for all those changes.

edonehoo
edonehoo approved these changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

thatblindgeye
thatblindgeye suggested changes Jul 16, 2025
View reviewed changes
@rebeccaalpert rebeccaalpert mentioned this pull request Jul 24, 2025
Open
@rebeccaalpert rebeccaalpert merged commit 62acb76 into patternfly:main Jul 28, 2025
7 checks passed
rebeccaalpert pushed a commit to rebeccaalpert/virtual-assistant that referenced this pull request Oct 24, 2025
@parthivrh @rebeccaalpert
feat(demo): Demo for drawer mode with display mode switcher (patternf…
55b2cf3 
…ly#601)

Adds demo for inline drawer functionality with display mode switcher to overlay and full screen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaylachumley kaylachumley kaylachumley approved these changes

+3 more reviewers

@rebeccaalpert rebeccaalpert rebeccaalpert approved these changes

@thatblindgeye thatblindgeye thatblindgeye requested changes

@edonehoo edonehoo edonehoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add demo for drawer mode with display mode switcher

6 participants

@parthivrh @patternfly-build @rebeccaalpert @edonehoo @thatblindgeye @kaylachumley