feat(messages): fill positive, negative, and copy action icons on click#812
Merged
thatblindgeye merged 9 commits intopatternfly:mainfrom Feb 17, 2026
Merged
Conversation
|
Preview: https://chatbot-pr-chatbot-812.surge.sh A11y report: https://chatbot-pr-chatbot-812-a11y.surge.sh |
Collaborator
|
@kaylachumley do we want to do anything with the "download" and "listen" icons, as those are filled icons by default? |
kmcfaul
approved these changes
Feb 17, 2026
thatblindgeye
requested changes
Feb 17, 2026
Comment on lines
165
to
168
Collaborator
There was a problem hiding this comment.
Spoke with Kayla, and we just want to make the tiniest of changes. Basically:
- for this PR, let's omit the copy action from the icon update on click and update any verbiage as necessary; instead we'll basically recommend using a filled icon for actions intended to persist
- I'm going to open a followup PR for updating the "listen" icon to an outlined variant (likely using RH brand icon), as well as adding that to this list of filled icons.
edonehoo
reviewed
Feb 17, 2026
Contributor
edonehoo
left a comment
edonehoo
left a comment
There was a problem hiding this comment.
a few content suggestions, feel free to iterate if you need to!
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/Messages.md
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/Messages/Messages.md
Outdated
Show resolved
Hide resolved
...ule/patternfly-docs/content/extensions/chatbot/examples/Messages/MessageWithIconSwapping.tsx
Outdated
Show resolved
Hide resolved
…mples/Messages/Messages.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
…mples/Messages/Messages.md Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
…mples/Messages/MessageWithIconSwapping.tsx Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
thatblindgeye
approved these changes
Feb 17, 2026
kaylachumley
approved these changes
Feb 17, 2026
|
🎉 This PR is included in version 6.6.0-prerelease.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #408
Assisted by Claude Code