This repository was archived by the owner on Feb 5, 2025. It is now read-only.
fix(inline-edit): modify combobox selector for inline edit for form#1048
Merged
matthewcarleton merged 1 commit intopatternfly:masterfrom May 2, 2018
Merged
fix(inline-edit): modify combobox selector for inline edit for form#1048matthewcarleton merged 1 commit intopatternfly:masterfrom
matthewcarleton merged 1 commit intopatternfly:masterfrom
Conversation
dgutride
approved these changes
May 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is to modify the selector class used in the inline edit for form. When trying to to consume this example for patternfly-org, the department field is broken (images shown in the PR link below). This fixes that issue.
Related to this PR: patternfly/patternfly-org#558
Changes
$('combobox').combobox();is now$('select.combobox').combobox();Link to rawgit and/or image
https://rawgit.com/amarie401/patternfly/combobox-dist/dist/tests/inline-edit-for-form.html