This repository was archived by the owner on Feb 5, 2025. It is now read-only.
feat(fixed-accordion): Add a Flexbox version of Fixed Height Accordion #1123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
jeff-phillips-18
force-pushed
the
flexbox-fixed-accordion
branch
from
780c8f5 to
6357729
Compare
Member
Author
|
@dabeng yeah, had just noticed that myself. Fixed. |
jeff-phillips-18
force-pushed
the
flexbox-fixed-accordion
branch
from
6357729 to
5c4790f
Compare
jeff-phillips-18
force-pushed
the
flexbox-fixed-accordion
branch
from
5c4790f to
5999ba3
Compare
jeff-phillips-18
requested review from
dgutride and
mcoker
and removed request for
dabeng
dgutride
approved these changes
Aug 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a fixed height accordion using flexbox rather than computing heights. Extra space is taken up by the open panel, thus collapsed panel headers are pushed to the bottom of the accordion.
Relates to #512
Link to rawgit
https://rawgit.com/jeff-phillips-18/patternfly/flexbox-fixed-accordion-dist/dist/tests/accordions.html