fix(deps): sass -> sassc switch

[ezr-ondrej]

Description

The sass gem is now deprecated and it's highly encouraged to move to the sassc.

As bootstrap already moved in twbs/bootstrap-sass@dcdef9b#diff-3dabc815e5a509f3166ca40cd58772da, the precision fixes probably don't even work now.

Once we move to font-awesome-sass 5, we would be the only one depending on sass, what is not situation we want I believe :)

Changes

• Switch from sass to sassc

[ezr-ondrej]

@jeff-phillips-18, @skateman, maybe @ares would you know who could get this one in?

[ezr-ondrej]

Ping?

[Ron-Lavi]

Thanks @ezr-ondrej, looks good to me 👍

[jeff-phillips-18]

👍

[jeff-phillips-18]

@redallen Could you take a look as well?

[redallen]

I know we have two SASS compilers in this project, this Ruby one and grunt-sass which uses node-sass. I believe the site is built using the Ruby one (which isn't hosted anywhere anymore), and grunt-sass is used to build the library.

In any case, node-sass isn't deprecated and plenty of people still use it. Sure, we can upgrade the Ruby one and I don't think it will affect much.

[mmoll]

A gem release with this would be super-nice 💟.

[skateman]

It should automatically happen, the patternfly-build user should have access.

[redallen]

Doesn't look like it... I kept rekicking the build until the flaky tests passed, but there's lacking permissions somewhere: https://travis-ci.org/github/patternfly/patternfly-3/builds/681579713#L3305

[ezr-ondrej]

Can we do something to help there? I can bump the gem version manually and then just someone needs to gem build and gem publish right?

[skateman]

I am the gem owner, so I guess only I can do it (and the patternfly-build user) so I'm gonna take a look.

[dgutride]

Seems like there is also a patternfly-build permission issue with publishing on patternfly-3

[redallen]

I updated the Github tokens, but now there's new problems:

Skipping a deployment with the rubygems provider because this repo's name does not match one specified in .travis.yml's deploy.on.repo: patternfly/patternfly

Skipping a deployment with the rubygems provider because this branch is not permitted: master

[patternfly-build]

🎉 This PR is included in version 3.59.5 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

[skateman]

Just got an email that the gem has been pushed successfully 🎉 thanks to whoever helped.

[redallen]

Looks like the build just passed and there should be a v3.59.5 out there.

Sorry it took so long, there were a lot of problems with the build...