Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Comments

removed main attribute in package.json#3

Merged
dlabrecq merged 1 commit intomasterfrom
main-attribute
Jul 29, 2016
Merged

removed main attribute in package.json#3
dlabrecq merged 1 commit intomasterfrom
main-attribute

Conversation

@priley86
Copy link
Member

@priley86 priley86 commented Jul 28, 2016 •
edited
Loading

  • determined this was necessary as npm publish complains about having multiple files in main attribute
  • moved express, ejs, and phantomjs to devDependencies to clean up our dependency tree in Patternfly

@priley86
Copy link
Member Author

priley86 commented Jul 28, 2016

@bleathem @dlabrecq any chance we can merge this today?

@priley86 priley86 mentioned this pull request Jul 28, 2016
Merged
@bleathem
Copy link
Member

bleathem commented Jul 28, 2016

This seems like a reasonable change to me.

👍

@dlabrecq
Copy link
Member

dlabrecq commented Jul 29, 2016

LGTM

@dlabrecq dlabrecq merged commit 04e4b0c into master Jul 29, 2016
@priley86
Copy link
Member Author

priley86 commented Jul 29, 2016

@dlabrecq awesome! thanks for helping turn this so quickly 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@priley86 @bleathem @dlabrecq