Skip to content

fix: Dataview v5 update#4436

Merged
nicolethoen merged 2 commits intov5from
v5-react-data-view
Jan 29, 2025
Merged

fix: Dataview v5 update#4436
nicolethoen merged 2 commits intov5from
v5-react-data-view

Conversation

@dlabaj
Copy link
Contributor

@dlabaj dlabaj commented Jan 15, 2025

Cherry picked Data view from v6 branch.

* feat: Added data view to the documentaion site.

* fixed path force source.

* Updated the examples path.

* fix: Updated to released version of the software.

* Rebase.
@dlabaj dlabaj requested review from evwilkin and kmcfaul January 15, 2025 22:33
Copy link
Collaborator

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add react-data-view to the documentation-site package.json

@evwilkin
Copy link
Member

+1 to Nicole's comment - mirroring the change from the V6 branch but with the v5 version of the extension got this building for me 👍

@dlabaj
Copy link
Contributor Author

dlabaj commented Jan 28, 2025

@nicolethoen @evwilkin All set.

@patternfly-build
Copy link
Collaborator

@nicolethoen nicolethoen merged commit 8876d05 into v5 Jan 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments