Skip to content

fix(getHtmlWebpackPlugins): Turn off pre-render for ChatBot #4467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolethoen merged 1 commit into from
Feb 17, 2025
Merged

fix(getHtmlWebpackPlugins): Turn off pre-render for ChatBot #4467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions packages/documentation-framework/scripts/webpack/getHtmlWebpackPlugins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,29 +5,25 @@ const { getTitle } = require('../../helpers/getTitle');

const templateDir = path.join(__dirname, '../../templates');

async function getHtmlWebpackPlugin({
isProd,
googleAnalyticsID,
algolia,
url,
title,
isFullscreen
}) {
async function getHtmlWebpackPlugin({ isProd, googleAnalyticsID, algolia, url, title, isFullscreen }) {
return new HtmlWebpackPlugin({
template: path.join(templateDir, 'html.ejs'),
filename: `${url}/index.html`.replace(/^\/+/, ''),
templateParameters: {
title: getTitle(title),
// Don't prerender fullscreen pages (expensive!)
prerendering: (isProd && !isFullscreen && !url.includes('topology') && !url.includes('extensions')) ? await prerender(url) : null,
prerendering:
isProd && !isFullscreen && !url.includes('chatbot') && !url.includes('topology') && !url.includes('extensions')
? await prerender(url)
: null,
// Don't use GA in dev mode
googleAnalyticsID: isProd ? googleAnalyticsID : false,
algolia
},
scriptLoading: 'defer',
inject: false,
minify: false
})
});
}

async function getHtmlWebpackPlugins(options) {
Expand All @@ -40,11 +36,11 @@ async function getHtmlWebpackPlugins(options) {
filename: 'sitemap.xml',
templateParameters: {
urls: Object.entries(routes)
.map(([path, { sources }]) => [path, ...(sources || []).slice(1).map(source => source.slug)])
.map(([path, { sources }]) => [path, ...(sources || []).slice(1).map((source) => source.slug)])
.flat()
},
inject: false,
minify: false,
minify: false
})
];

Expand All @@ -59,7 +55,7 @@ async function getHtmlWebpackPlugins(options) {
.map(([url, { sources = [], title, isFullscreen }]) => [
[url, { title, isFullscreen }],
// Add pages for sources
...sources.slice(1).map(source => [source.slug, source])
...sources.slice(1).map((source) => [source.slug, source])
])
.flat()
.sort();
Expand All @@ -70,7 +66,7 @@ async function getHtmlWebpackPlugins(options) {

console.log('done prerendering');
return res;
};
}

module.exports = {
getHtmlWebpackPlugins
Expand Down
Loading