chore(many): design guidelines assets#4498
chore(many): design guidelines assets#4498andrew-ronaldson merged 12 commits intopatternfly:mainfrom
Conversation
edonehoo
left a comment
edonehoo
left a comment
There was a problem hiding this comment.
I called out a few hopefully easy fixes, but lmk if you have thoughts/concerns with any of my suggestions! Ty for talking the alert beast
There was a problem hiding this comment.
I checked the figma file and it looks like the token marker annotations were outside of the frame, so they didn't export with this image. I fixed it in figma, so if you re-export and upload then I think you'll be good to go
There was a problem hiding this comment.
this one is also missing annotations!
There was a problem hiding this comment.
I know this image is replicating the existing one, but I feel like the current one is longer than it needs to be. Could we try making the image more of a horizontal spread? I made a new frame in figma called "alert-types-erin" (which you can just rename) for what I was thinking, but I'm open to feedback if we want to keep this format
There was a problem hiding this comment.
For this one, can you change the field label for the 2 errored inputs to be "Version" and "Region"? Just to align with the link names used in the error
4 participants
Closing:
#4273
#4462
#4463